Skip to:
Content

Opened 3 months ago

Closed 2 months ago

#7563 closed defect (bug) (fixed)

Welcome Screen for BP 2.9.0

Reported by: mercime Owned by: djpaul
Milestone: 2.9 Priority: normal
Severity: normal Version:
Component: Core Keywords: has-patch has-screenshots commit
Cc:

Description

Attachments (11)

bp-2-9.png (327.0 KB) - added by mercime 2 months ago.
First pass
bp-tooltip.gif (398.1 KB) - added by mercime 2 months ago.
edit-group-slug.png (10.3 KB) - added by mercime 2 months ago.
fieldset.png (7.9 KB) - added by mercime 2 months ago.
7563.patch (15.3 KB) - added by mercime 2 months ago.
7563-2.patch (16.7 KB) - added by mercime 2 months ago.
bp-2-9-2nd.png (288.9 KB) - added by mercime 2 months ago.
7563-3.patch (16.7 KB) - added by mercime 2 months ago.
Correct spelling of "user".
7563-4.patch (17.1 KB) - added by hnla 2 months ago.
Remove stray empty string.
7563-5.patch (1.1 KB) - added by netweb 2 months ago.
7563-6.patch (1.8 KB) - added by netweb 2 months ago.

Download all attachments as: .zip

Change History (31)

#1 @r-a-y
3 months ago

Thanks for opening this ticket, mercime.

Headline feature should probably be the edit slug feature for Groups in the WP admin dashboard (#6014).

Secondary highlights (pick some of these, but probably not all):

  • a11y (#7348, #7421, #7546)
  • Tooltips (#7188)
  • Better support for private message thread links in emails (#7349)
  • Better compatibility with WordPress themes powered by Bootstrap (Fixes issues with content being hidden in the groups loop and activity comments). (#7443, #7490, #7542)
  • Better support for uploads (Fixes issues with uploading in iOS Safari and uploading files with non-ASCII filenames) (#7416, #7484)

This is just a guideline. Feel free to make whatever changes, everyone!

#2 @mercime
3 months ago

Thanks for the guideline r-a-y :D Screenshots: 800px x 500px for featured items.

This ticket was mentioned in Slack in #buddypress by r-a-y. View the logs.


2 months ago

@mercime
2 months ago

First pass

@mercime
2 months ago

@mercime
2 months ago

@mercime
2 months ago

#4 @mercime
2 months ago

  • Keywords has-patch has-screenshots added

7563.patch - first pass for welcome screen

#5 @hnla
2 months ago

I was going to suggest running a block of four primary features, given we lack huge big features this release i.e a11y, tooltip, edit slug,7397 omit sending invites to users already received invites.

But you have things underway so do what you think best.

#6 @mercime
2 months ago

@hnla Comments/feedback/suggestions most welcome from everyone as usual. Just to be clear, no main feature just the four you mentioned: a11y = profile fieldsets, tooltip, edit slug, and 7397.

At this time, I only have images for the profile fieldset, tooltip, and edit slug. None for 7397 that I can think of. So will be coming up with a patch using dashicons.

#7 @hnla
2 months ago

Well my thought was we don't really have a single big splash feature to set on it's own so better to do a group and ? list some smaller ones below, but you've done good with previous screens so trust in your judgement on it.

@mercime
2 months ago

@mercime
2 months ago

#8 follow-up: @mercime
2 months ago

Feedback please on new patch with screenshot attached. Thanks :D

#9 in reply to: ↑ 8 @netweb
2 months ago

Replying to mercime:

Feedback please on new patch with screenshot attached. Thanks :D

I love it :)

@mercime
2 months ago

Correct spelling of "user".

#10 @mercime
2 months ago

Thanks for your feedback @netweb :D

This ticket was mentioned in Slack in #buddypress by djpaul. View the logs.


2 months ago

#12 @hnla
2 months ago

Last iteration looks great.

@hnla
2 months ago

Remove stray empty string.

#13 @hnla
2 months ago

  • Keywords commit added

@mercime Going ahead and committing this, if we need to make changes so be it, hopefully it will be minor so shouldn't cause translators too much work.

#14 @hnla
2 months ago

And forgot to reference the ticket: r11646

Last edited 2 months ago by hnla (previous) (diff)

#15 @hnla
2 months ago

There are a couple of translation concerns as mentioned on slack:
https://wordpress.slack.com/archives/C02RQBYUG/p1500114992978161

@netweb
2 months ago

This ticket was mentioned in Slack in #buddypress by netweb. View the logs.


2 months ago

@netweb
2 months ago

#18 @hnla
2 months ago

@netweb thanks.

#19 @hnla
2 months ago

We need to revisit this the second change is echoing html elements as strings.

#20 @djpaul
2 months ago

  • Owner set to djpaul
  • Resolution set to fixed
  • Status changed from new to closed

In 11648:

Credits screen: improve translation accessibility of certain strings.

Fixes #7563

Props mercime, hnla, netweb, slaffik, offereins.

Note: See TracTickets for help on using tickets.