Skip to:

Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#7542 closed defect (bug) (fixed)

bp-legacy: Fix "Show all comments" count for activity comments

Reported by: r-a-y's profile r-a-y Owned by: r-a-y's profile r-a-y
Milestone: 2.9 Priority: normal
Severity: normal Version: 1.8
Component: Templates Keywords: has-patch


While looking at #7490, I noticed a few things with the "Show all comments" count for activity comments.

To duplicate, create at least 6 first-level activity comments under an activity update and check the "Show all comments" count.

You'll notice the following:

  • The "Show all comments" count under an activity update doesn't show up when logged out
  • The "Show all comments" count doesn't increase or decrease properly when posting a new activity comment or deleting an activity comment.

Attachments (1)

7542.01.patch (1.9 KB) - added by r-a-y 7 years ago.

Download all attachments as: .zip

Change History (5)

7 years ago

#1 @r-a-y
7 years ago

  • Milestone changed from Awaiting Review to 2.9
  • Version set to 1.8

Related: #4844, r7002.

#2 @r-a-y
7 years ago

In 11600:

bp-legacy: Fix "Show All Comments" count for logged-out users.

Previously, the "Show All Comments" button in activity threads did not
show the comment count for non-authenticated users. The problem was we
were relying on looking for the reply link to do the count, which is only
available for authenticated users.

This commit addresses this.

See #7542.

#3 @r-a-y
7 years ago

  • Owner set to r-a-y
  • Resolution set to fixed
  • Status changed from new to closed

In 11601:

bp-legacy: Fix incrementing and decrementing the "Show All Comments" count in activity threads.

Previously, if a user posts a new activity comment or deletes an activity
comment, the "Show All Comments" count would not update.

This commit addresses this.

Fixes #7542.

This ticket was mentioned in Slack in #buddypress by hnla. View the logs.

7 years ago

Note: See TracTickets for help on using tickets.