Opened 12 years ago
Closed 12 years ago
#4844 closed defect (bug) (fixed)
Show all X comments should update when comments are deleted
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 1.8 | Priority: | low |
Severity: | minor | Version: | 1.7 |
Component: | Activity | Keywords: | has-patch |
Cc: |
Description
When you delete comments the amount in the show all link doesn't change. If you delete and then click the show all, it show's all the comments including the previously deleted comments.
Create 7 comments
Refresh page to get "show all X comments" link
Delete a few comments no change to amount
Click the show all link previously deleted comments reappear
Attachments (1)
Change History (10)
#2
@
12 years ago
http://dev.taptappress.com/admin/activity/639/
You can see the show all. when you are logged in it says show all 6 comments. If you delete a comment the number doesn't change and if you delete and then click the show all link it shows the previously deleted comments.
#3
@
12 years ago
Made y'all a video of it https://vimeo.com/60201330
#4
@
12 years ago
- Component changed from Core to Activity
- Keywords needs-patch added; reporter-feedback removed
- Milestone changed from Awaiting Review to 1.8
- Priority changed from normal to low
- Severity changed from normal to minor
Thanks for the additional details. I've confirmed both issues. Neither one is a regression; the same problems appear in the 1.6 branch.
#6
@
12 years ago
- Keywords has-patch added; needs-patch removed
fadeOut just sets the item's display property to none and leaves it in the DOM. Added a callback to it to remove it from the DOM after the effect is completed.
I don't think updating the X in "Show all X comments" is worth the trouble. I think it's pretty understandable from the user's point of view.
#8
@
12 years ago
I don't think updating the X in "Show all X comments" is worth the trouble. I think it's pretty understandable from the user's point of view.
I might've been tempted to agree with this. But then I looked at the way this string is currently generated, and was so repulsed that I knew it had to be rewritten :) Basically, we were piecing it together like this: "Show all" + " " + comment_count + " " + "comments". Beyond being breathtakingly ugly, this is extremely untranslatable.
I've refactored the way that the show-all text is generated, so that (a) it's possible to translate it, and (b) it's easy to write javascript to update the number after deletion. Win-win!
Can you be more specific about what you mean by "comments"? Do you mean activity replies? If so, I can't reproduce the issue - the "x comments" button changes as I'd expect (and also, I don't see a "show all" link).