Skip to:
Content

BuddyPress.org

Opened 2 years ago

Closed 15 months ago

#7541 closed enhancement (fixed)

Disabled "select/deselect all components" checkbox on bp-components page

Reported by: pavlo.opanasenko Owned by: slaFFik
Milestone: 3.0 Priority: low
Severity: minor Version: 2.5.0
Component: Administration Keywords: has-patch commit
Cc:

Description

The admin cannot select or deselect all the optional components at once because the checkbox is disabled.
Link: buddypress.dev/wp-admin/options-general.php?page=bp-components
The checkbox blocking was made in #6803.

The purpose of checkbox unblocking is to let admin select/deselect all components at once.

Attachments (6)

7541.patch (1.2 KB) - added by pavlo.opanasenko 2 years ago.
Enabled checkbox, changed accessibility label text.
7541.2.patch (2.0 KB) - added by pavlo.opanasenko 2 years ago.
Enabled checkbox, changed accessibility label text.
7541.3.patch (1.0 KB) - added by pavlo.opanasenko 18 months ago.
Removed checkboxes from core components on bp-components page (mobile tested)
7541.4.patch (3.6 KB) - added by pavlo.opanasenko 18 months ago.
Cumulative patch. Includes:
7541.5.patch (1.1 KB) - added by mercime 15 months ago.
7541.6.patch (1.3 KB) - added by pavlo.opanasenko 15 months ago.

Download all attachments as: .zip

Change History (27)

#1 @slaFFik
2 years ago

I agree with this improvement. You will need to change the accessibility text as well.

@pavlo.opanasenko
2 years ago

Enabled checkbox, changed accessibility label text.

#2 @pavlo.opanasenko
2 years ago

  • Keywords has-patch added
  • Milestone changed from Awaiting Review to 2.9

@pavlo.opanasenko
2 years ago

Enabled checkbox, changed accessibility label text.

#3 @hnla
2 years ago

  • Milestone changed from 2.9 to Awaiting Review

Are we sure why the checkbox was set as disabled in the first place?

#4 @mercime
2 years ago

@hnla I replaced empty table cells to fix accessibility and to improve visual presentation with disabled checkboxes per screenshots and commit in #6803.

I have no strong feelings about enabling/disabling either way. At that time, I opted for the disabled state since the option to enable bulk de/activation of all components was not there in the first place. I had also thought that other developers could have concerns after handing over the completed BP sites to clients who might mess the up the site if they bulk enable/disable all components.

Cheers.

#5 @DJPaul
2 years ago

The checkboxes not working annoy me as much as clicking the component label, does nothing.

#6 @hnla
2 years ago

  • Keywords commit added

#7 @DJPaul
2 years ago

  • Milestone changed from Awaiting Review to Future Release

@slaFFik do you remember if this was ready to commit or did this still have an edge case with something being preselected?

#8 @slaFFik
2 years ago

@DJPaul
There are some edge cases that should be addressed. I will talk to @pavlo.opanasenko to hunt them down.

But in general - can we hide checkboxes for components that can't be deactivated?

#9 @DJPaul
2 years ago

We trust you to make decisions. So, yes.

#10 @DJPaul
19 months ago

@slaFFik Any interest in finishing this?

#11 @slaFFik
19 months ago

Yes, either @pavlo.opanasenko or me will finish that for 3.0 release.

#12 @pavlo.opanasenko
19 months ago

Sorry for abandoning this. I will post a patch soon.

@pavlo.opanasenko
18 months ago

Removed checkboxes from core components on bp-components page (mobile tested)

@pavlo.opanasenko
18 months ago

Cumulative patch. Includes:

#13 @pavlo.opanasenko
18 months ago

7541.4.patch​ is a cumulative patch.

Changes included:

  • "Select All" checkbox for bp-components is active and functional;
  • Component title click activates the component checkbox;
  • Core components checkboxes HTML is deleted;

#14 @slaFFik
18 months ago

  • Milestone changed from Future Release to 3.0

#15 @slaffik
18 months ago

  • Resolution set to fixed
  • Status changed from new to closed

In 11801:

Administration: Ability to bulk select/deselect components.

The bulk selection checkbox for components was disabled. This commit enables it, plus makes every component name clickable, that checks appropriate component.

Props pavlo.opanasenko.
Fixes #7541.

#16 @mercime
15 months ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

We need to remove both the duplicate <label> with a redundant aria-label attribute.

Patch coming up.

@mercime
15 months ago

#17 @mercime
15 months ago

7541.5.patch brings back the code for this section to 2.9 branch.

#18 @pavlo.opanasenko
15 months ago

Here's a minor contribution to the latest patch to make the whole component title clickable.

#19 @DJPaul
15 months ago

Great work everyone, 6.patch works great from my perspective.

The labels here not being clickable have literally annoyed me for years, so I will buy people cake if we can get this new patch in.

@mercime Will you commit this if you're happy?

This ticket was mentioned in Slack in #buddypress by djpaul. View the logs.


15 months ago

#21 @mercime
15 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 11914:

Administration: Remove redundant aria-label attribute from label element.

Props pavlo.opanasenko.
Fixes #7541.

Note: See TracTickets for help on using tickets.