Disabled "select/deselect all components" checkbox on bp-components page

[pavlo.opanasenko]

The admin cannot select or deselect all the optional components at once because the checkbox is disabled.
Link: buddypress.dev/wp-admin/options-general.php?page=bp-components
The checkbox blocking was made in #6803.

The purpose of checkbox unblocking is to let admin select/deselect all components at once.

[slaFFik]

I agree with this improvement. You will need to change the accessibility text as well.

[pavlo.opanasenko]

Enabled checkbox, changed accessibility label text.

[pavlo.opanasenko]

Enabled checkbox, changed accessibility label text.

[hnla]

Are we sure why the checkbox was set as disabled in the first place?

[mercime]

@hnla I replaced empty table cells to fix accessibility and to improve visual presentation with disabled checkboxes per screenshots and commit in #6803.

I have no strong feelings about enabling/disabling either way. At that time, I opted for the disabled state since the option to enable bulk de/activation of all components was not there in the first place. I had also thought that other developers could have concerns after handing over the completed BP sites to clients who might mess the up the site if they bulk enable/disable all components.

Cheers.

[DJPaul]

The checkboxes not working annoy me as much as clicking the component label, does nothing.

[DJPaul]

@slaFFik do you remember if this was ready to commit or did this still have an edge case with something being preselected?

[slaFFik]

@DJPaul
There are some edge cases that should be addressed. I will talk to @pavlo.opanasenko to hunt them down.

But in general - can we hide checkboxes for components that can't be deactivated?

[DJPaul]

We trust you to make decisions. So, yes.

[DJPaul]

@slaFFik Any interest in finishing this?

[slaFFik]

Yes, either @pavlo.opanasenko or me will finish that for 3.0 release.

[pavlo.opanasenko]

Sorry for abandoning this. I will post a patch soon.

[pavlo.opanasenko]

Removed checkboxes from core components on bp-components page (mobile tested)

[pavlo.opanasenko]

Cumulative patch. Includes:

[pavlo.opanasenko]

7541.4.patch​ is a cumulative patch.

Changes included:

• "Select All" checkbox for bp-components is active and functional;
• Component title click activates the component checkbox;
• Core components checkboxes HTML is deleted;

[slaffik]

In 11801:

Administration: Ability to bulk select/deselect components.

The bulk selection checkbox for components was disabled. This commit enables it, plus makes every component name clickable, that checks appropriate component.

Props pavlo.opanasenko.
Fixes #7541.

[mercime]

We need to remove both the duplicate <label> with a redundant aria-label attribute.

Patch coming up.

[mercime]

7541.5.patch brings back the code for this section to ​2.9 branch.

[pavlo.opanasenko]

Here's a minor contribution to the latest patch to make the whole component title clickable.

[DJPaul]

Great work everyone, 6.patch works great from my perspective.

The labels here not being clickable have literally annoyed me for years, so I will buy people cake if we can get this new patch in.

@mercime Will you commit this if you're happy?

[mercime]

In 11914:

Administration: Remove redundant aria-label attribute from label element.

Props pavlo.opanasenko.
Fixes #7541.