Skip to:
Content

BuddyPress.org

Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#7546 closed enhancement (fixed)

General settings form field markup

Reported by: henry.wright Owned by: mercime
Milestone: 2.9 Priority: normal
Severity: normal Version:
Component: Settings Keywords: commit
Cc:

Description

The "New Password" and "Repeat New Password" text in the settings form appears after the associated input field(s) which could be confusing to some users. I suggest we move the text so it appears before the input(s). I also suggest we use <label> markup around this text.

Attachments (5)

Screenshot 2017-06-20 at 14.44.49.png (49.9 KB) - added by henry.wright 2 years ago.
legacy-settings-general.png (11.4 KB) - added by mercime 2 years ago.
per patch
7546.patch (1.8 KB) - added by mercime 2 years ago.
7546.2.patch (1.7 KB) - added by mercime 2 years ago.
updated
legacy-settings-general-2.png (9.9 KB) - added by mercime 2 years ago.
as seen in 2014 theme

Download all attachments as: .zip

Change History (15)

This ticket was mentioned in Slack in #buddypress by henrywright. View the logs.


2 years ago

#2 @hnla
2 years ago

@henry.wright Please point to the offending file where label elements don't exist.

As far back as https://buddypress.trac.wordpress.org/attachment/ticket/6531/6531-settings-general.patch mercime updated to add a label element but other labels did exist before this.

Edit Ok see what you meant but that bare naked abomination passing as text wasn't a label, I was taking literally the remark about no labels when there were two albeit one being visually hidden but that was for a reason to ensure existing layouts didn't change yet provide the correct Stndards markup where possible. Now this has been changed you will affect layouts but hey ho!

Last edited 2 years ago by hnla (previous) (diff)

@mercime
2 years ago

per patch

@mercime
2 years ago

#3 @mercime
2 years ago

@henry.wright as @hnla mentioned above, I added a label a while back in r10089 but had made it for screen readers only to keep in line with the design at the time.

Glad you brought this up though as it gave an opportunity to improve the accessibility of the form after r10089. Attached 7546.patch with screenshot:

  • Made the label for "pass2" visible by removing the bp-screen-reader-text class
  • Removed the redundant text "Repeat New Password" after the input field for "pass2"
  • Associated "New Password" with the input field for "pass1"

#4 @hnla
2 years ago

'New Password' just looks a bit out of place now - this is the problem in expending energy on these old templates, nothing short of re-writing fully is worth the effort.

@mercime
2 years ago

updated

@mercime
2 years ago

as seen in 2014 theme

#5 @mercime
2 years ago

@hnla updated screenshot and patch which removes "New Password" :)

#6 @hnla
2 years ago

@mercime yep looks much better don't you think? perhaps we update ( leave blank for no change ) to ( Enter new password, leave blank for no change ) - no more than a passing thought though.

Prefer the wider submit is that a change or was that done in companion styles for a tablet screen view? i.e is this a diff browser view?

Last edited 2 years ago by hnla (previous) (diff)

#7 @mercime
2 years ago

yep looks much better don't you think?

@hnla yes :D

perhaps we update ( leave blank for no change ) ... no more than a passing thought though.

Suggest that we keep text to what's already there

Prefer the wider submit is that a change or was that done in companion styles for a tablet screen view? i.e is this a diff browser view

I was checking the patch on the twenty-xxx themes and the Twenty Fourteen theme was at bat when I took the screenshot on Chrome.

Last edited 2 years ago by mercime (previous) (diff)

#8 @hnla
2 years ago

  • Keywords commit added

#9 @mercime
2 years ago

  • Owner set to mercime
  • Resolution set to fixed
  • Status changed from new to closed

In 11607:

Improve markup of Members settings - general screen.

Props mercime, hnla.
Fixes #7546.

#10 @mercime
2 years ago

  • Milestone changed from Awaiting Review to 2.9
Note: See TracTickets for help on using tickets.