Skip to:
Content

BuddyPress.org

Opened 2 years ago

Closed 22 months ago

#7545 closed enhancement (fixed)

Move composer.json to project root

Reported by: DJPaul Owned by: netweb
Milestone: 3.0 Priority: normal
Severity: normal Version:
Component: Build/Test Tools Keywords:
Cc:

Description

BuddyPress provides a composer.json (for Composer/Packagist) in the release builds. In the development builds, it lives in /src.

I'd like to move this file into the root of the development build, and add tooling to our build scripts to copy it into the root of the release build.

This would be to allow us to use Composer libraries to help with development, as well as using Composer libraries for the release build. Wwe don't do either of these at the moment, but the latter's technically supported. I'd like the former option possible, too.

Change History (6)

#1 @johnjamesjacoby
2 years ago

I am +1 on this idea, if it's achievable.

See: https://github.com/composer/composer/issues/183

#2 follow-up: @netweb
2 years ago

Reading the Composer issue I see https://github.com/wikimedia/composer-merge-plugin comes out well recommended, a quick search of GitHub surfaced this gem https://github.com/solsoft/wordpress-boilerplate/blob/4.x/composer.json, looks like a solid example of composer-merge-plugin in a WP context

Last but not least, BPs composer.json is already in the root of the repo, though I understand the intent behind the this ticket and I'm +1 on these enhancements https://buddypress.svn.wordpress.org/trunk/composer.json

Related: #7228 Add PHPCS

#3 @DJPaul
2 years ago

  • Milestone changed from Awaiting Review to 3.0

great find Netweb!

#4 in reply to: ↑ 2 @netweb
22 months ago

  • Keywords close added

Replying to netweb:

BPs composer.json is already in the root of the repo, though I understand the intent behind the this ticket and I'm +1 on these enhancements https://buddypress.svn.wordpress.org/trunk/composer.json

Composer was moved from /src to the repo root in [11038], it is copied to the /build folder with a Grunt task

#5 @netweb
22 months ago

  • Keywords close removed

#6 @DJPaul
22 months ago

  • Resolution set to fixed
  • Status changed from new to closed

This was done in some previous release.

Note: See TracTickets for help on using tickets.