Change error message "The user is already active."

[flimm]

When clicking on the activation link in an email, if the user has already clicked it, you get this error message:

The user is already active.

It would be good if the error message instructed the user to log in next, so that the user is not lost.

[DJPaul]

Hi @flimm

That's a good idea to improve the flow; rather than block them with an error, we can just say "your account is ready" on the log-in form.

[yahil]

@DJPaul @flimm I like to work on this ticket but not able to reproduce, can you guys help me..

I have already clicked on activation link and Once again I was trying to click on activation like.
it's showing Invalid activation key.

Not able to see The user is already active.

Am I missing something or am I going wrong?

Thanks,
Yahil :)

[flimm]

I got an email saying

To complete the activation of your account, go to the following link: ​http://example.com/activate/xyz

If I click on that link after I have already activated the account, the website shows this error:

Activate Your Account
The user is already active.
Please provide a valid activation key.

You can grep the codebase for this error message. I found it in wp-content/plugins/buddypress/bp-members/bp-members-functions.php and wp-includes/ms-functions.php.

[DJPaul]

@flimm Did you find this issue with multisite enabled?

[flimm]

Yes.

[yahil]

Okey, Let me check with multisite :)

Replying to flimm:

Yes.

[DJPaul]

You might also want to consider changing the messages/flow for non-multisite. Ideally I think it'd be nice to have all messages shown on the registration flow the same.