#7562 closed defect (bug) (fixed)
Activity's friends component filter fails since 4.8
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 2.8.3 | Priority: | normal |
Severity: | normal | Version: | 2.8.0 |
Component: | Templates | Keywords: | has-patch dev-feedback |
Cc: |
Description
Hi everyone,
I've just met bp_activity_get_actions_for_context()
. This function was introduced in 4.8 and according to the inline comment targets to get a flat list of activity actions compatible with a given context.
The problem of it happens when an action is a comma separated value like 'friendship_accepted,friendship_created'
(the value of the Activity friends component filter). In this case the action parameter of the query string is not build, and you get the entire activity stream instead of only the friends component activities. So it's a regression.
I think we should simply handle comma separated values as filters more generally. We only use them for the friends component but it can make sense to create a new custom filter with more than one activity type.
That's why i'm suggesting to edit the bp-templates/bp-legacy/buddypress-functions.php
instead of the activity context function.
In 11650: