Skip to:
Content

Opened 7 months ago

Closed 2 weeks ago

#7564 closed defect (bug) (fixed)

A forgotten %s in french translation is making the Activity JavaScript to fail with favorites.

Reported by: imath Owned by: slaFFik
Milestone: 3.0 Priority: normal
Severity: normal Version: 2.8.2
Component: I18N Keywords: i18n-change 2nd-opinion
Cc:

Description

The favorites count on the activity directory tab is used to check if we need to remove this nav in case the total favourites is 0.

As the current translation is missing the %s placeholder, the count is not appearing and when you remove 2 favorites from there, it's removing the tab although there are still favorites.

I've just suggested this fix on the Polyglots tool:
https://translate.wordpress.org/projects/wp-plugins/buddypress/stable/fr/default?filters%5Bstatus%5D=either&filters%5Boriginal_id%5D=1383980&filters%5Btranslation_id%5D=50488227

But i think something should be done to avoid the translation to make a feature fail.

Change History (4)

#1 @r-a-y
6 months ago

Hi @imath,

Is this something that needs to be done on GlotPress? It looks like you are a Contributor, but not an Editor. I'm not sure if GlotPress contributors can accept changes.

@danbp appears to be the French editor:
https://translate.wordpress.org/locale/fr/default/wp-plugins/buddypress

Maybe he can confirm your change?

#2 @imath
6 months ago

hi r-a-y,

Yes the glotpress suggestion should be validated. But i also think we could use a context or a /* Transalors: */ comment to inform why it's important to include the placeholder in the translation.

#3 @DJPaul
6 months ago

  • Milestone changed from Awaiting Review to 3.0

Sure.

#4 @djpaul
2 weeks ago

  • Resolution set to fixed
  • Status changed from new to closed

In 11790:

Templates, BP-Legacy: add translation hint for "My favorites %s" placeholder on Activity directory tabs.

Fixes #7564

Note: See TracTickets for help on using tickets.