Stop offering bp-default on new installations
|Reported by:||boonebgorges||Owned by:||boonebgorges|
|Component:||Theme||Keywords:||has-patch needs-testing 2nd-opinion|
As of 1.9, we should no longer offer bp-default as an installable theme for new installations. This will be the first step in the longer-term task of removing bp-default from the BP codebase, and spinning it out into its own theme. See #5212 for more general discussion.
My proposed solution is to bail out of registering the bp-themes theme directory unless one of the following cases obtains:
- The current theme is bp-default (get_stylesheet())
- The current theme is a child of bp-default (get_template())
If anyone thinks that this is too aggressive, we could do the above *only for new installations*. How can we tell what's a new installation? We could add something to the 1.9 upgrade routine that sets a flag in the database - something like bp_register_bp_default - to true, while that value would be set to false (or unset) for new installs.
Patch incoming for the simpler, more aggressive option.
Change History (8)
comment:5 follow-up: ↓ 6 boonebgorges — 4 months ago
- Owner set to boonebgorges
- Resolution set to fixed
- Status changed from new to closed