Enable upgrade route for BP-Default for future BP releases
|Reported by:||DJPaul||Owned by:|
The BuddyPress team and many contributors have previously discussed moving BP-Default out of the main BuddyPress package and onto the WordPress.org/themes repo. When this happens is TBC, but some prep work is required to make the transition as straightforward as possible.
We have two main reasons to do this:
- After BP 1.9, we plan no further improvements or bug fixes for BP-Default (unless it's a security issue).
- We'd like to remove BP-Default from the BuddyPress codebase to bring down the size of the plugin, and have a kind-of clean slate for future theme development with the theme compatibility approach that we've adopted.
What needs to happen is to move the theme from inside the BuddyPress plugin folder into the /themes/ folder. Or to put it another way, for 1.9, I suggest that we do not register the /buddypress/bp-themes/ folder if BP-Default exists in /themes/.
The attached patch is an implementation of this. It's a pretty simple change. I couldn't get any of the helpful methods in wp-includes/theme.php to work here, partly because static variables are used to save theme information, and this caused problems with checking/registering the themes here. It looks like it *should* be possible; it might be a load-order issue.
How will this help us? Some point after 1.9 ships, we get BP-Default up on wordpress.org/themes/, and bump the version number. This will cause everyone's WordPresses to see that there's a new version of BP-Default, and hopefully they'll click the update button. WordPress will download that updated theme into /themes/. On next page load, our patch then takes affect, and doesn't register the version of BP-Default bundled with BuddyPress.
At some version in the future, we'd just delete the bundled BP-Default from BuddyPress.