Skip to:

Opened 11 years ago

Closed 11 years ago

#5213 closed defect (bug) (fixed)

Set better HTTP headers for RSS feeds

Reported by: r-a-y's profile r-a-y Owned by: r-a-y's profile r-a-y
Milestone: 1.9 Priority: normal
Severity: normal Version: 1.8
Component: Activity Keywords:


BP's activity RSS feeds need to support ETag and browser cache invalidation to mirror WP's feed support.

Attachments (1)

5213.01.patch (3.2 KB) - added by r-a-y 11 years ago.

Download all attachments as: .zip

Change History (2)

11 years ago

#1 @r-a-y
11 years ago

  • Owner set to r-a-y
  • Resolution set to fixed
  • Status changed from new to closed

In 7477:

Set better HTTP headers for activity RSS feeds.

Previously, BP's RSS feeds would use WP's native HTTP headers set in the
WP::send_headers() method. This would cause BuddyPress to inherit WP
feed's "ETag" and HTTP status headers.

When trying to refresh BP's RSS feeds, this would not work correctly due
to BP relying on WP's post last modified date instead of BP's activity last
updated date. This would lead to a HTTP 304 Not Modified status header
being sent by WP, meaning the client (browser, RSS reader) would not fetch
the latest items from the activity stream.

This commit sets the appropriate HTTP headers for BP's activity RSS feeds
and uses a new, internal class method - http_headers() - to set them.

Fixes #5213.

Note: See TracTickets for help on using tickets.