Changeset 7569

Timestamp:

11/13/2013 02:47:20 AM (11 years ago)

Author:

boonebgorges

Message:

Sound the knell for the BuddyPress Default theme

bp-default is being sunsetted as of BP 1.9. The theme will continue to receive
security updates and other critical fixes, but will otherwise no longer be
under active development by the core team.

We maintain backward compatibility with sites currently using bp-default by
continuing to register the bp-themes theme directory when bp-default, or a
child theme thereof, is in use on a given site. Those sites will continue to
be able to use the theme. Installations where bp-default is not already in use
will no longer see it listed on Dashboard > Appearance.

Site administrators or developers who want to override this behavior may do so
with the 'bp_do_register_theme_directory' filter. Please note that bp-themes
will be removed altogether from BuddyPress in a future version, likely migrated
to wordpress.org/extend. See #5212.

Now cracks a noble heart. Good-night, sweet prince;
And flights of angels sing thee to thy rest.

Fixes #5223

Location:

trunk

Files:

• bp-core/bp-core-functions.php (modified) (1 diff)
• bp-loader.php (modified) (1 diff)
• bp-themes/bp-default/style.css (modified) (2 diffs)

trunk/bp-core/bp-core-functions.php

@@ -531 +531 @@
 function bp_core_add_illegal_names() {
     update_site_option( 'illegal_names', get_site_option( 'illegal_names' ), array() );
+}
+
+/**
+ * Determine whether BuddyPress should register the bp-themes directory.
+ *
+ * @since BuddyPress (1.9.0)
+ *
+ * @return bool True if bp-themes should be registered, false otherwise.
+ */
+function bp_do_register_theme_directory() {
+    $register = 'bp-default' === get_stylesheet() || 'bp-default' === get_template();
+    return apply_filters( 'bp_do_register_theme_directory', $register );
 }
 

trunk/bp-loader.php

@@ -525 +525 @@
 
     /**
-     * Setup the BuddyPress theme directory
-     *
-     * @since BuddyPress (1.5)
-     * @todo Move bp-default to wordpress.org/extend/themes and remove this
+     * Set up BuddyPress's legacy theme directory.
+     *
+     * Starting with version 1.2, and ending with version 1.8, BuddyPress
+     * registered a custom theme directory - bp-themes - which contained
+     * the bp-default theme. Since BuddyPress 1.9, bp-themes is no longer
+     * registered (and bp-default no longer offered) on new installations.
+     * Sites using bp-default (or a child theme of bp-default) will
+     * continue to have bp-themes registered as before.
+     *
+     * @since BuddyPress (1.5.0)
+     *
+     * @todo Move bp-default to wordpress.org/extend/themes and remove this.
      */
     public function register_theme_directory() {
+        if ( ! bp_do_register_theme_directory() ) {
+            return;
+        }
+
         register_theme_directory( $this->old_themes_dir );
     }

trunk/bp-themes/bp-default/style.css

@@ -2 +2 @@
  * Theme Name: BuddyPress Default
  * Theme URI: http://buddypress.org/extend/themes/
- * Description: Clean and stylish, BuddyPress Default lets you build a social network straight out of the box. Make it yours with a custom menu, header image, and background. Along with five widgetized areas (one in the sidebar, four in the footer), BP-Default supports featured images (as custom header images on posts and pages) and is furnished with an optional one-column page template that removes the sidebar, and a stylesheet for the admin Visual Editor.
+ * Description: [NOTE: except for security issues, BuddyPress Default is no longer being actively maintained by the BuddyPress team.] Clean and stylish, BuddyPress Default lets you build a social network straight out of the box. Make it yours with a custom menu, header image, and background. Along with five widgetized areas (one in the sidebar, four in the footer), BP-Default supports featured images (as custom header images on posts and pages) and is furnished with an optional one-column page template that removes the sidebar, and a stylesheet for the admin Visual Editor.
  * Version: 1.8
  * Author: the BuddyPress team
@@ -10 +10 @@
  * Tags: blue, buddypress, custom-background, custom-header, custom-menu, editor-style, featured-image-header, featured-images, fixed-width, light, right-sidebar, rtl-language-support, sticky-post, threaded-comments, translation-ready, two-columns, white
  *
- *** IMPORTANT - DO NOT COPY THIS THEME **
+ *** IMPORTANT ***
+ *
+ * BuddyPress Default is no longer being actively developed by the BuddyPress team.
  *
  * If you want to make a custom theme based on this theme, DO NOT copy and edit it. By