Skip to:
Content

BuddyPress.org

Opened 10 years ago

Closed 10 years ago

#5211 closed defect (bug) (fixed)

Sitewide activity feed broken when activity component set as front page

Reported by: r-a-y's profile r-a-y Owned by: boonebgorges's profile boonebgorges
Milestone: 1.9 Priority: normal
Severity: normal Version:
Component: Core Keywords: has-patch
Cc:

Description (last modified by r-a-y)

Due to changes in r7437, the sitewide activity feed is broken when the activity component is set as the front page.

I've attached a quick patch to address this, but am unsure if this is the best way to address this,

Attachments (3)

5211.01.patch (827 bytes) - added by r-a-y 10 years ago.
5211.02.patch (1.3 KB) - added by r-a-y 10 years ago.
5211.03.patch (956 bytes) - added by boonebgorges 10 years ago.

Download all attachments as: .zip

Change History (5)

@r-a-y
10 years ago

#1 @r-a-y
10 years ago

  • Description modified (diff)
  • Summary changed from Sitewide activity feed broken since r7437 to Sitewide activity feed broken when activity component set as front page

@r-a-y
10 years ago

#2 @boonebgorges
10 years ago

  • Owner set to boonebgorges
  • Resolution set to fixed
  • Status changed from new to closed

In 7471:

Don't canonical redirect page_on_front if bp_current_action() is populated

When looking at a BP component and bp_current_action() is empty, it means that
the item is (1) not a single item (like a group or member), and (2) not a feed
request. Therefore, it's a good way to infer whether a page is a directory
page, and ought to be considered for redirecting to directory page_on_front
settings.

This fixes the problem of /activity/feed/ being redirected to the front page
when the Activity directory was set to page_on_front.

Fixes #5211

Props r-a-y

Note: See TracTickets for help on using tickets.