Skip to:
Content

BuddyPress.org

Opened 7 years ago

Closed 6 years ago

Last modified 6 years ago

#5325 closed defect (bug) (fixed)

Continue to register theme directory in perpetuity if bp-default was ever active

Reported by: boonebgorges Owned by: boonebgorges
Milestone: 1.9.2 Priority: high
Severity: major Version: 1.9
Component: Core Keywords: 2nd-opinion has-patch
Cc: info@…

Description

I have seen a number of support issues arise related to the deprecation of bp-default and our invisible de-registering of the bp-themes directly. Namely, when users of bp-default switch away from the theme (for testing, etc), and find that it's no longer available for them to reactivate.

In #5223, I originally suggested that we set a flag for existing users of bp-default, but in the end it was not implemented. In retrospect, I think this is a mistake. It may affect a relatively small number of users, but it's a very big shock to find that your longtime theme has completely disappeared. This is something that we should have implemented in the first place. I'm glad to take the blame, but I think it's something we should fix ASAP so as to avoid more confusion.

Attachments (1)

5325.patch (2.6 KB) - added by boonebgorges 7 years ago.

Download all attachments as: .zip

Change History (7)

#1 @boonebgorges
7 years ago

  • Keywords has-patch added

5325.patch has my suggested solution. If another dev has any severe objections to the general technique (or suggestions for improvements), please let me know.

@boonebgorges
7 years ago

#2 @DJPaul
7 years ago

I don't really mind but I think this still isn't bullet-proof on multisite setups. I'd rather we loop back to #5212 sooner rather than later.

#3 @boonebgorges
7 years ago

Thanks for the feedback.

I think this still isn't bullet-proof on multisite setups

Yeah. It won't help in cases where bp-default is being run on a secondary site, but not the main site. But this is an edge case of an edge case, and it'd take a lot more machinery to figure out how to fix (looping through every single blog on the network does not seem wise). So I think my suggestion is a fair compromise.

I'd rather we loop back to #5212 sooner rather than later.

Yup, let's definitely do so, but do it in addition to this more immediate fix, not instead of it.

#4 @wdfee
6 years ago

  • Cc info@… added

On my site/network I use a child theme of bp-default. bp-default disappeared and I can't use the child theme anymore...

#5 @johnjamesjacoby
6 years ago

  • Resolution set to fixed
  • Status changed from new to closed

In 7795:

Set a switch to retain ye olde bp-default theme if it's been activated previously. Fixes issues with theme switching, and bp-default disappearing. Props boonebgorges. Fixes #5325. (1.9 branch)

#6 @johnjamesjacoby
6 years ago

In 7798:

Set a switch to retain ye olde bp-default theme if it's been activated previously. Fixes issues with theme switching, and bp-default disappearing. Props boonebgorges. Fixes #5325. (trunk)

Note: See TracTickets for help on using tickets.