Skip to:
Content

Opened 3 years ago

Closed 3 years ago

#3241 closed defect (bug) (fixed)

BP-Default 1.5 - master ticket.

Reported by: DJPaul Owned by:
Milestone: 1.5 Priority: major
Severity: normal Version: 1.5
Component: Theme Keywords:
Cc:

Description (last modified by DJPaul)

This is a master ticket for changes to be made to BP-Default 1.3. Tickets were created from feedback from a theme review by Mercime.

#3234 - Long site title doesn't fit in header area
#3235 - Table and image caption spacing
#3236 - Add more info to 404 Page
#3237 - Use wp_link_pages() in index.php and archive.php
#3238 - Post title on single.php links to itself
#3239 - Sticky posts styling not working on all indexes
#3242 - blog comment spacing does not match activity stream spacing
#3253 - Nested activity comment reply breaks after level 2

Attachments (2)

default.css (50.1 KB) - added by karmatosed 3 years ago.
defaultgradients.diff (6.9 KB) - added by karmatosed 3 years ago.

Download all attachments as: .zip

Change History (37)

comment:1 bowromir3 years ago

I'dd like to work on

the Search.php template
the 404 template
The index.php and archive.pjp templates to use wp_link_pages :)

I'll start working on them today.

comment:2 karmatosed3 years ago

I assigned myself #3235 and #3238 and submitted patches.

Last edited 3 years ago by karmatosed (previous) (diff)

comment:3 karmatosed3 years ago

#3239 has a patch also now.

comment:4 karmatosed3 years ago

#3234 has a patch also now. As you're working on them will leave the other ones to you bowromir.

comment:5 hnla3 years ago

I'll take a look at #3237 - it should be fairly straightforward to do.

comment:6 DJPaul3 years ago

  • Description modified (diff)

comment:7 DJPaul3 years ago

#3242 added to the list

comment:8 DJPaul3 years ago

  • Description modified (diff)

comment:10 DJPaul3 years ago

  • Description modified (diff)

comment:12 DJPaul3 years ago

  • Description modified (diff)

comment:13 johnjamesjacoby3 years ago

(In [4782]) Fix issue where private messages could not be marked as read, unread, or deleted. See #3367, #3241.

comment:14 johnjamesjacoby3 years ago

(In [4783]) Fix updated subnav span style when viewing a private message conversation. See #3241.

comment:15 DJPaul3 years ago

  • Description modified (diff)
  • Severity set to normal

comment:16 djpaul3 years ago

(In [4808]) Tweak 'in reply to' styling on activity stream, and improve i18n. See #3241

comment:17 djpaul3 years ago

(In [4812]) Fix duplicate IDs. See #3241

comment:18 djpaul3 years ago

(In [4836]) Move sticky post styling to author-box. See #3241

comment:19 djpaul3 years ago

(In [4858]) Add new view_link parameter to bp_member_latest_update() to control generation of 'view' link or not.
Update members activity stream to not show the "view" links next to users' latest updates, as they can easily click through into the user's profile. See #3241

comment:20 djpaul3 years ago

(In [4860]) Tidy up margins on group 'send invites' screen, and only show scrollbars in the invitee list if they're needed. See #3241

comment:21 djpaul3 years ago

(In [4861]) Remove "you are logged in as..." text from the comment reply form to improve appearance. See #3241

comment:22 djpaul3 years ago

(In [4871]) Fix width of forum tags sidebar "widget". See #3241

comment:23 DJPaul3 years ago

The activity permalink page's RTL styles needs fixing

comment:24 djpaul3 years ago

(In [4906]) Don't set opacity on from status message paragraphs. See #3415 and #3241

comment:25 akash_bug3 years ago

  • Summary changed from BP-Default 1.3 - master ticket. to BP-Default 1.5 - master ticket.
  • Version set to 1.5

comment:26 djpaul3 years ago

(In [4914]) RTL fix to container border. See #3241

comment:27 DJPaul3 years ago

There's a strange RTL issue around the #message styles which I can't figure out; the left and right borders (or edges) are cut off. See screenshot at http://i53.tinypic.com/2570rvq.png

comment:28 celticwarrior723 years ago

The following issues apply to my installation of BP 1.5 Beta 2 on Laughing Squid hosting:

1) 'Name' defaults to 'Username' upon registration and cannot be changed later in 'Profile'
2) Once an item is 'Favorited' the number of favorites is incremented under 'Activity' but that number does not get decremented when the 'Favorite' is deleted or unfavorited
3) 'Username' is restricted to "lowercase letters and numbers". Please can we have "Username" restricted just to "letters and numbers" like BuddyPress.org? I'm not sure if this is a bug.

comment:29 DJPaul3 years ago

We have inconsistent use of the linear-gradient selector in the stylesheet. We need to patch these so that we use all the selectors that we do for #header. Note that #header has its IE6-9 filter selector intentionally omitted.

comment:30 modemlooper3 years ago

The header gradient is awful. It looks like a huge button. I'm not apposed to gradients but it just looks bad. Like its sticking out. The center is lighter than the top flip those 2 colors and it will look 10x better. :)

comment:31 karmatosed3 years ago

I can work on a patch tomorrow (may be Monday now) to get things consistent. I do however think contrasts could also be increased but that probably is for the other ticket debate :)

Personally I don't really like colours we've got going on but that's such a personal choice I'm groovy so long as it's all consistent which currently is what I feel it's not. I also think as said contrasts could be increased.

Last edited 3 years ago by karmatosed (previous) (diff)

comment:32 DJPaul3 years ago

celticwarrior72 - It's easiest to keep separate issues each in their own tickets please. But:

1) Works for me. I suggest you post on the BuddyPress.org forums and we can talk around and dig into this a bit more.
2) Works for me. I assume we're looking at the tab count on the main /activity/ page.
3) See #2207

comment:33 karmatosed3 years ago

I did some work on this tonight but haven't been able to fully test. I'm attaching it though as not able to do work on this for the next few days and don't want to hold things up by what I've done. I attach the stylesheet with my changes and a diff but it's not a tested patch.

karmatosed3 years ago

karmatosed3 years ago

comment:34 djpaul3 years ago

(In [4979]) Gradients for everyone! Props to karmatosed for initial patch. See #3241

comment:35 DJPaul3 years ago

  • Resolution set to fixed
  • Status changed from new to closed

I'm going to close this ticket; anything new will have to wait for the next bus, and any bugs reported will likely be reported on individual tickets.

Note: See TracTickets for help on using tickets.