Skip to:
Content

Opened 8 years ago

Closed 8 years ago

Last modified 3 years ago

#3237 closed defect (bug) (fixed)

Use wp_link_pages() in index.php and archive.php

Reported by: DJPaul Owned by: hnla
Milestone: 1.5 Priority: normal
Severity: Version: 1.5
Component: Templates Keywords:
Cc: hugoashmore@…

Description

Review feedback: "wp_link_pages should also be included the following template files:

  • index.php
  • archive.php"

http://codex.wordpress.org/Theme_Development#Template_File_Checklist

Attachments (3)

3237-post-page-pag-links.patch (1.6 KB) - added by hnla 8 years ago.
Adds wp_link_pages() to index.php & archive.php
bp-archive-page-pag.jpg (15.6 KB) - added by hnla 8 years ago.
page view of pag pages links - archive
bp-index-page-pag.jpg (20.9 KB) - added by hnla 8 years ago.
page view post pag links - index

Download all attachments as: .zip

Change History (8)

#1 @hnla
8 years ago

  • Cc hugoashmore@… added
  • Owner set to hnla
  • Status changed from new to accepted

@hnla
8 years ago

Adds wp_link_pages() to index.php & archive.php

@hnla
8 years ago

page view of pag pages links - archive

@hnla
8 years ago

page view post pag links - index

#2 @hnla
8 years ago

Files patched as per example SC.

Default-ish wp_link_pages() args passed as in 2010 i.e before => <div class="page-links">

No styling applied class .page-links acquires existing bp-default styles for:

.edit-link, .page-links { clear: both; }

As this is a list of links the markup really should reflect that by using a ul construct. On brief perusal of codex I don't think it's possible to pass 'li' element args easily if at all, but will recheck but it would leave an issue with what to do with anonymous inline text box ( the bear naked cdata 'Pages' existing in the div)

#3 @DJPaul
8 years ago

Thanks for the patch, hnla!

I've taken the <strong> out and put it into CSS, and I've found where we've used wp_link_pages() in some of the existing templates, and added the same markup so it's identical across all the templates.

#4 @djpaul
8 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

(In [4412]) Use wp_link_pages() in all theme templates. Fixes #3237, props hnla

#5 @DJPaul
3 years ago

  • Component changed from Appearance - Template Parts to Templates
Note: See TracTickets for help on using tickets.