Skip to:
Content

Opened 8 years ago

Closed 8 years ago

Last modified 3 years ago

#3234 closed defect (bug) (fixed)

Long site title doesn't fit in header area

Reported by: DJPaul Owned by: DJPaul
Milestone: 1.5 Priority: normal
Severity: Version: 1.5
Component: Templates Keywords:
Cc: Dennissmolek

Description

Long Site Title - "The Big Brown Fox Jumps Over the Lazy Dog"

The beginning of the title is pushed up to behind the BP Admin Bar.

Review feedback: "This can be addressed by adding documentation in readme.txt file about the limitations for the site title and/or how to allow for long site title using the theme by e.g. sharing CSS solution to allow for long site title."

It would be preferable to see if there are any tweaks that can be made to HTML/CSS to accommodate this.

Attachments (7)

01-theme-check.jpg (25.7 KB) - added by DJPaul 8 years ago.
short.jpg (13.4 KB) - added by karmatosed 8 years ago.
long.jpg (23.7 KB) - added by karmatosed 8 years ago.
titlespacing.diff (301 bytes) - added by karmatosed 8 years ago.
3234-2.patch (3.2 KB) - added by DJPaul 8 years ago.
long-meta-header-with-no margin-note-fav-button.jpg (10.3 KB) - added by hnla 8 years ago.
SC showing view.delete links vanishing behind fav button
long-meta-header-with-margin-right-to clear.jpg (9.8 KB) - added by hnla 8 years ago.
SC showing margin-right margin to clear fav button

Download all attachments as: .zip

Change History (20)

@DJPaul
8 years ago

#1 @karmatosed
8 years ago

  • Owner set to karmatosed
  • Status changed from new to accepted

#2 @karmatosed
8 years ago

Attached suggestion I changed the spacing at bottom and also line height. I've also included a screenshot of what happens to the header now both with a long and short title.

@karmatosed
8 years ago

@karmatosed
8 years ago

#3 @karmatosed
8 years ago

Passing to you Paul for confirmation.

#4 @karmatosed
8 years ago

  • Owner changed from karmatosed to DJPaul
  • Status changed from accepted to assigned

#5 @hnla
8 years ago

Just as a foot note to this issue. the reason - as Tammie has alluded to - for this issue is the use of a percentage value for line-height and in understanding why that is generally not an advisable approach, generally line-height should be expressed as a commuted value e.g '1.3'

I note that the body font has also been set as a percentage value and if it hasn't ought to be changed.

#6 @DJPaul
8 years ago

@hnla Where do we set any font as a %?

@DJPaul
8 years ago

#7 @DJPaul
8 years ago

3234-2.patch is a different approach; I've taken out the line-height et al, and the absolute positioning from that and the search form elements. I have assumed the design intention was to try to get the title and the search form on the same vertical level, so this patch also improves that and general positioning. Feedback and testing appreciated :)

#8 @hnla
8 years ago

I was referring to the shorthand font property declaration on body the line-height has been set as % it should not be really no line-heights should be set as % or em else compound inheritance issues will follow. Remove the line-height from the heading tag, change body to something like 1.3 unit-less (value is then computed from the actual element inheriting that line-height

I can tell that the original intent was to use line-height as a positioning property which it is not and should not be used as it's the leading value for inline text, margins position/space block elements.

#9 @hnla
8 years ago

In looking at the ticket for comment spacing I've noticed that we also have an issue with the activity meta header and looong group names see attached SC(or any long names I guess) I'll add a fix for this on the patch for the comment spacing but it has consequences.

@hnla
8 years ago

SC showing view.delete links vanishing behind fav button

@hnla
8 years ago

SC showing margin-right margin to clear fav button

#10 @Dennissmolek
8 years ago

  • Cc Dennissmolek added

@hnla, dont forget the reply button if you are a member. I was testing it and 130px seems to work for me.

#11 @hnla
8 years ago

Yep did take into account the reply button just after taking the SC which was really just to illustrate the issue.

#12 @djpaul
8 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [4418]) Fit a longer site title into the page header. Fixes #3234, props karmatosed for initial patch

#13 @DJPaul
3 years ago

  • Component changed from Appearance - Template Parts to Templates
Note: See TracTickets for help on using tickets.