Skip to:
Content

BuddyPress.org

Opened 10 years ago

Closed 10 years ago

Last modified 5 years ago

#3367 closed enhancement (fixed)

1.5 beta code clean-up master ticket

Reported by: johnjamesjacoby Owned by:
Milestone: 1.5 Priority: normal
Severity: normal Version: 1.5
Component: Core Keywords:
Cc: sharma.aks34@…

Description

With beta right around the corner, it's time to do some code tidying to clean up any new function names, class names, and filters we've introduced in the 1.3 cycle. I'm:

  • Auditing/removing PHP4 constructors
  • Class functions that start with underscores
  • require_once() usage where require() will provide a performance benefit

There are surely more things to tidy, so this is a general master ticket to commit code clean-up against.

Change History (26)

#1 @johnjamesjacoby
10 years ago

(In [4775]) Prebeta code clean-up - see #3367:

  • Remove PHP4 constructors on loader classes
  • Remove class functions that start with underscores
  • Use require() rather than require_once() where appropriate
  • Remove background color on messages activity time

#2 @johnjamesjacoby
10 years ago

(In [4776]) Fix bug where inbox count would return incorrect results. See #3367.

#3 @johnjamesjacoby
10 years ago

(In [4782]) Fix issue where private messages could not be marked as read, unread, or deleted. See #3367, #3241.

#4 @johnjamesjacoby
10 years ago

(In [4786]) Replace {unknown} @since with 1.3. See #3367.

#5 @boonebgorges
10 years ago

(In [4788]) Don't re-require activity notification functions, already included in component class. See #3367

#6 @boonebgorges
10 years ago

(In [4794]) Cleans up require()s in BP installation process. Fixes #3369. See #3367

#7 @boonebgorges
10 years ago

(In [4795]) More require() cleanup. See #3367

#8 @boonebgorges
10 years ago

(In [4799]) Don't load friends notifications file multiple times. See #3367

#9 @boonebgorges
10 years ago

(In [4801]) Don't load groups-notifications.php file after it's loaded in the main component class. See #3367

#10 @djpaul
10 years ago

(In [4816]) Set the unix date as the version identifier to script and style enqueues. See #3367

#11 @djpaul
10 years ago

(In [4817]) Add ABSPATH checks to Activity component. See #3367

#12 @djpaul
10 years ago

(In [4819]) Add ABSPATH checks to Blogs tracking component. See #3367

#13 @djpaul
10 years ago

(In [4820]) Add ABSPATH checks to Core component. See #3367

#14 @djpaul
10 years ago

(In [4821]) Add ABSPATH checks to Forums component. See #3367

#15 @djpaul
10 years ago

(In [4822]) Add ABSPATH checks to Friends component. See #3367

#16 @djpaul
10 years ago

(In [4823]) Add ABSPATH checks to Groups component. See #3367

#17 @djpaul
10 years ago

(In [4824]) Add ABSPATH checks to Members component. See #3367

#18 @djpaul
10 years ago

(In [4825]) Add ABSPATH checks to Messages component. See #3367

#19 @djpaul
10 years ago

(In [4826]) Add ABSPATH checks to Settings component. See #3367

#20 @djpaul
10 years ago

(In [4827]) Add ABSPATH checks to Profile component. See #3367

#21 @akash_bug
10 years ago

  • Summary changed from 1.3 beta code clean-up master ticket to 1.5 beta code clean-up master ticket
  • Version set to 1.5

#22 @djpaul
10 years ago

(In [4934]) Cast some limit pagination integers. See #3367

#23 @boonebgorges
10 years ago

(In [4948]) Use require_once() when requiring plugins.php and activating BP Template Pack during wizard. Reverts part of r4775; see #3367. Fixes #3459.

#24 @akash_bug
10 years ago

  • Cc sharma.aks34@… added
  • Resolution set to fixed
  • Status changed from new to closed

#25 @johnjamesjacoby
10 years ago

In the future please do not close tickets without them being marked as such by a member of the core team.

Leaving this as closed since I think our clean up for 1.5 is complete.

#26 @DJPaul
5 years ago

  • Type changed from task to enhancement
Note: See TracTickets for help on using tickets.