1.5 beta code clean-up master ticket

[johnjamesjacoby]

With beta right around the corner, it's time to do some code tidying to clean up any new function names, class names, and filters we've introduced in the 1.3 cycle. I'm:

• Auditing/removing PHP4 constructors
• Class functions that start with underscores
• require_once() usage where require() will provide a performance benefit

There are surely more things to tidy, so this is a general master ticket to commit code clean-up against.

[johnjamesjacoby]

(In [4775]) Prebeta code clean-up - see #3367:

• Remove PHP4 constructors on loader classes
• Remove class functions that start with underscores
• Use require() rather than require_once() where appropriate
• Remove background color on messages activity time

[johnjamesjacoby]

(In [4776]) Fix bug where inbox count would return incorrect results. See #3367.

[johnjamesjacoby]

(In [4782]) Fix issue where private messages could not be marked as read, unread, or deleted. See #3367, #3241.

[johnjamesjacoby]

(In [4786]) Replace {unknown} @since with 1.3. See #3367.

[boonebgorges]

(In [4788]) Don't re-require activity notification functions, already included in component class. See #3367

[boonebgorges]

(In [4794]) Cleans up require()s in BP installation process. Fixes #3369. See #3367

[boonebgorges]

(In [4795]) More require() cleanup. See #3367

[boonebgorges]

(In [4799]) Don't load friends notifications file multiple times. See #3367

[boonebgorges]

(In [4801]) Don't load groups-notifications.php file after it's loaded in the main component class. See #3367

[djpaul]

(In [4816]) Set the unix date as the version identifier to script and style enqueues. See #3367

[djpaul]

(In [4817]) Add ABSPATH checks to Activity component. See #3367

[djpaul]

(In [4819]) Add ABSPATH checks to Blogs tracking component. See #3367

[djpaul]

(In [4820]) Add ABSPATH checks to Core component. See #3367

[djpaul]

(In [4821]) Add ABSPATH checks to Forums component. See #3367

[djpaul]

(In [4822]) Add ABSPATH checks to Friends component. See #3367

[djpaul]

(In [4823]) Add ABSPATH checks to Groups component. See #3367

[djpaul]

(In [4824]) Add ABSPATH checks to Members component. See #3367

[djpaul]

(In [4825]) Add ABSPATH checks to Messages component. See #3367

[djpaul]

(In [4826]) Add ABSPATH checks to Settings component. See #3367

[djpaul]

(In [4827]) Add ABSPATH checks to Profile component. See #3367

[djpaul]

(In [4934]) Cast some limit pagination integers. See #3367

[boonebgorges]

(In [4948]) Use require_once() when requiring plugins.php and activating BP Template Pack during wizard. Reverts part of r4775; see #3367. Fixes #3459.

[johnjamesjacoby]

In the future please do not close tickets without them being marked as such by a member of the core team.

Leaving this as closed since I think our clean up for 1.5 is complete.