Skip to:
Content

BuddyPress.org

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#8892 closed defect (bug) (fixed)

Need to removed unused variable.

Reported by: upadalavipul Owned by: imath
Priority: normal Milestone: 12.0.0
Component: Core Version:
Severity: normal Keywords: has-patch
Cc:

Description

I have reviewed the BuddyPress code and found that some of the files in unused variables define and it's not used anywhere. Please check the below files.

Files:

  • src/bp-blogs/bp-blogs-activity.php
  • src/bp-blogs/bp-blogs-filters.php
  • src/bp-members/classes/class-bp-members-invitation-manager.php
  • src/bp-members/classes/class-bp-members-list-table.php
  • src/bp-members/classes/class-bp-members-ms-list-table.php

Attachments (9)

8892.patch​ (2.9 KB ) - added by upadalavipul 3 years ago.
8892.2.patch​ (3.8 KB ) - added by upadalavipul 3 years ago.
few more files in found unused variable.
8892.3.patch​ (2.8 KB ) - added by upadalavipul 3 years ago.
few more files in found unused variable.
8892.4.patch​ (3.2 KB ) - added by upadalavipul 3 years ago.
few more files in found unused variable.
8892.5.patch​ (3.2 KB ) - added by upadalavipul 3 years ago.
few more files in found unused variable.
#8892.patch​ (1.7 KB ) - added by kajalgohel 3 years ago.
Removed unused variable from the few files
8892.6.patch​ (917 bytes ) - added by viralsampat 3 years ago.
I have checked above mentioned issue and founds few files. Here, I have added its patch.
8892.7.patch​ (6.0 KB ) - added by upadalavipul 3 years ago.
few more files in found unused variable.
8892.8.patch​ (1.1 KB ) - added by upadalavipul 3 years ago.
few more files in found unused variable.

Download all attachments as: .zip

Change History (19)

@upadalavipul
3 years ago

#1 @imath
3 years ago

  • Keywords has-patch added
  • Milestone Awaiting Review → 12.0.0

Thanks for your review & patch. I will check it asap 👌

#2 @imath
3 years ago

  • Owner set to imath
  • Resolution → fixed
  • Status new → closed

In 13476:

Remove never used inited variables in Blogs & Members components

Props upadalavipul

Fixes #8892

@upadalavipul
3 years ago

few more files in found unused variable.

@upadalavipul
3 years ago

few more files in found unused variable.

#3 @imath
3 years ago

  • Resolution fixed
  • Status closed → reopened

Thanks for these new patches @upadalavipul I'll check & commit them asap.

This ticket was mentioned in ​PR #113 on ​buddypress/buddypress by ​@imath.
3 years ago #4

Remove never used inited variables in various functions

Trac ticket: ​https://buddypress.trac.wordpress.org/ticket/8892

#5 @imath
3 years ago

  • Resolution → fixed
  • Status reopened → closed

In 13497:

Core, Activity & Notifications: remove never used inited variables

Props upadalavipul

Fixes #8892
Closes ​https://github.com/buddypress/buddypress/pull/113

@upadalavipul
3 years ago

few more files in found unused variable.

@upadalavipul
3 years ago

few more files in found unused variable.

#6 @imath
3 years ago

  • Resolution fixed
  • Status closed → reopened

Thanks for these new patches @upadalavipul 👍

This ticket was mentioned in ​PR #115 on ​buddypress/buddypress by ​@imath.
3 years ago #7

Remove more never used inited variables in various functions

Trac ticket: ​https://buddypress.trac.wordpress.org/ticket/8892

@kajalgohel
3 years ago

Removed unused variable from the few files

@viralsampat
3 years ago

I have checked above mentioned issue and founds few files. Here, I have added its patch.

#8 @imath
3 years ago

  • Resolution → fixed
  • Status reopened → closed

In 13500:

Core, Activity: remove more never used inited variables in functions

Props upadalavipul, kajalgohel, viralsampat

Fixes #8892
Closes ​https://github.com/buddypress/buddypress/pull/115

@upadalavipul
3 years ago

few more files in found unused variable.

@upadalavipul
3 years ago

few more files in found unused variable.

This ticket was mentioned in ​PR #118 on ​buddypress/buddypress by ​@imath.
3 years ago #9

Remove even more never used inited variables in various functions!

Trac ticket: ​https://buddypress.trac.wordpress.org/ticket/8892

#10 @imath
3 years ago

In 13504:

Core, Messages & Templates: remove never used inited vars in functions

Props upadalavipul

Fixes #8892
Closes ​https://github.com/buddypress/buddypress/pull/118

Note: See TracTickets for help on using tickets.