Changeset 13476

Timestamp:

05/13/2023 09:19:10 AM (3 years ago)

Author:

imath

Message:

Remove never used inited variables in Blogs & Members components

Props upadalavipul

Fixes #8892

Location:

trunk/src

Files:

• bp-blogs/bp-blogs-activity.php (modified) (2 diffs)
• bp-blogs/bp-blogs-filters.php (modified) (3 diffs)
• bp-members/classes/class-bp-members-invitation-manager.php (modified) (1 diff)
• bp-members/classes/class-bp-members-list-table.php (modified) (1 diff)
• bp-members/classes/class-bp-members-ms-list-table.php (modified) (1 diff)

trunk/src/bp-blogs/bp-blogs-activity.php

@@ -955 +955 @@
         // Get the comment status.
         $post_comment_status = wp_get_comment_status( $post_comment_id );
-        $old_comment_status  = $post_comment_status;
 
         // No need to edit the activity, as it's the activity who's updating the comment.
@@ -1418 +1417 @@
 
         if ( ! empty( $blog_comment_id ) ) {
-                $bp = buddypress();
 
                 // Check if a comment action id is set for the parent activity.

trunk/src/bp-blogs/bp-blogs-filters.php

@@ -78 +78 @@
  */
 function bp_blogs_post_pre_publish( $return = true, $blog_id = 0, $post_id = 0, $user_id = 0 ) {
-        $bp = buddypress();
 
         // If blog is not trackable, do not record the activity.
@@ -91 +90 @@
         $sitewide_tags_blog_settings = bp_core_get_root_option( 'sitewide_tags_blog' );
         if ( ! empty( $sitewide_tags_blog_settings ) ) {
-                $st_options = maybe_unserialize( $sitewide_tags_blog_settings );
+                $st_options   = maybe_unserialize( $sitewide_tags_blog_settings );
                 $tags_blog_id = isset( $st_options['tags_blog_id'] ) ? $st_options['tags_blog_id'] : 0;
         } else {
@@ -105 +104 @@
          * @param bool $value Current status of the sitewide tags activity.
          */
-        if ( (int) $blog_id == $tags_blog_id && apply_filters( 'bp_blogs_block_sitewide_tags_activity', true ) ) {
+        if ( (int) $blog_id === $tags_blog_id && apply_filters( 'bp_blogs_block_sitewide_tags_activity', true ) ) {
                 return false;
         }

trunk/src/bp-members/classes/class-bp-members-invitation-manager.php

@@ -52 +52 @@
                                 return false;
                         }
-
-                        $inviter_ud = bp_core_get_core_userdata( $invitation->inviter_id );
 
                         $invite_url = esc_url(

trunk/src/bp-members/classes/class-bp-members-list-table.php

@@ -366 +366 @@
                         return;
                 }
-
-                $profile_field_ids = array();
 
                 // Fetch registration field data once only.

trunk/src/bp-members/classes/class-bp-members-ms-list-table.php

@@ -359 +359 @@
 
                 if ( bp_is_active( 'xprofile' ) ) {
-                        $profile_field_ids = array();
 
                         // Fetch registration field data once only.