Changeset 13500

Timestamp:

06/10/2023 06:22:42 AM (3 years ago)

Author:

imath

Message:

Core, Activity: remove more never used inited variables in functions

Props upadalavipul, kajalgohel, viralsampat

Fixes #8892
Closes ​https://github.com/buddypress/buddypress/pull/115

Location:

trunk/src

Files:

• bp-activity/bp-activity-notifications.php (modified) (3 diffs)
• bp-activity/bp-activity-template.php (modified) (1 diff)
• bp-core/bp-core-buddybar.php (modified) (2 diffs)
• bp-core/classes/class-bp-block.php (modified) (1 diff)
• bp-core/classes/class-bp-core-bp-nav-backcompat.php (modified) (1 diff)
• bp-core/classes/class-bp-invitation-manager.php (modified) (2 diffs)
• bp-core/classes/class-bp-media-extractor.php (modified) (1 diff)

trunk/src/bp-activity/bp-activity-notifications.php

@@ -43 +43 @@
 
                         /* translators: %s: the current user display name */
-                        $title  = sprintf( __( '@%s Mentions', 'buddypress' ), bp_get_loggedin_user_username() );
+                        $text   = sprintf( __( '@%s Mentions', 'buddypress' ), bp_get_loggedin_user_username() );
                         $amount = 'single';
 
@@ -58 +58 @@
                 case 'update_reply':
                         $link   = bp_get_notifications_permalink();
-                        $title  = __( 'New Activity reply', 'buddypress' );
+                        $text   = __( 'New Activity reply', 'buddypress' );
                         $amount = 'single';
 
@@ -77 +77 @@
                 case 'comment_reply':
                         $link   = bp_get_notifications_permalink();
-                        $title  = __( 'New Activity comment reply', 'buddypress' );
+                        $text   = __( 'New Activity comment reply', 'buddypress' );
                         $amount = 'single';
 

trunk/src/bp-activity/bp-activity-template.php

@@ -3191 +3191 @@
 function bp_activity_can_comment() {
         global $activities_template;
-        $bp = buddypress();
 
         // Determine ability to comment based on activity type name.

trunk/src/bp-core/bp-core-buddybar.php

@@ -120 +120 @@
  */
 function bp_core_create_nav_link( $args = '', $component = 'members' ) {
-        $bp = buddypress();
-
         $defaults = array(
                 'component_id'            => '',    // The component ID registering this nav item.
@@ -539 +537 @@
  */
 function bp_core_create_subnav_link( $args = '', $component = 'members' ) {
-        $bp = buddypress();
-
         $r = bp_parse_args(
                 $args,

trunk/src/bp-core/classes/class-bp-block.php

@@ -196 +196 @@
                         if ( ! isset( $this->registered_scripts['editor_script'] ) || ! $this->registered_scripts['editor_script'] ) {
                                 $this->block = new WP_Error( 'script_registration_error', __( 'The required `editor_script` could not be registered.', 'buddypress' ) );
+
+                                // Register the styles.
                         } else {
-                                // Register the styles.
-                                $registered_styles = array();
 
                                 foreach ( array( 'editor_style', 'style' ) as $style_handle_key ) {

trunk/src/bp-core/classes/class-bp-core-bp-nav-backcompat.php

@@ -217 +217 @@
          */
         protected function get_nav( $offset ) {
-                $bp = buddypress();
-
                 $component_nav = $this->get_component_nav( $offset );
                 $primary_nav   = $component_nav->get_primary( array( 'slug' => $offset ), false );

trunk/src/bp-core/classes/class-bp-invitation-manager.php

@@ -170 +170 @@
          */
         public function send_invitation_by_id( $invitation_id = 0, $args = array() ) {
-                $updated = false;
-
                 $invitation = new BP_Invitation( $invitation_id );
 
@@ -328 +326 @@
          */
         public function send_request_notification_by_id( $request_id = 0, $args = array() ) {
-                $updated = false;
-
                 $request = new BP_Invitation( $request_id );
 

trunk/src/bp-core/classes/class-bp-media-extractor.php

@@ -520 +520 @@
         protected function extract_embeds( $richtext, $plaintext, $extra_args = array() ) {
                 $data   = array( 'has' => array( 'embeds' => 0 ), 'embeds' => array() );
-                $embeds = array();
 
                 if ( ! function_exists( '_wp_oembed_get_object' ) ) {