Ticket #8892: 8892.4.patch

src/bp-core/bp-core-buddybar.php

@@ -119 +119 @@
  * @return false|array Returns false on failure, new nav item on success.
  */
 function bp_core_create_nav_link( $args = '', $component = 'members' ) {
-        $bp = buddypress();
 
         $defaults = array(
                 'component_id'            => '',    // The component ID registering this nav item.
@@ -538 +537 @@
  * @return false|array Returns false on failure, new BP_Core_Nav_Item instance on success.
  */
 function bp_core_create_subnav_link( $args = '', $component = 'members' ) {
-        $bp = buddypress();
 
         $r = bp_parse_args(
                 $args,

src/bp-core/classes/class-bp-block.php

@@ -197 +197 @@
                                 $this->block = new WP_Error( 'script_registration_error', __( 'The required `editor_script` could not be registered.', 'buddypress' ) );
                         } else {
                                 // Register the styles.
-                                $registered_styles = array();
 
                                 foreach ( array( 'editor_style', 'style' ) as $style_handle_key ) {
                                         if ( ! isset( $wp_args[ $style_handle_key ] ) || ! $wp_args[ $style_handle_key ] ) {

src/bp-core/classes/class-bp-core-bp-nav-backcompat.php

@@ -216 +216 @@
          * @return bool|array
          */
         protected function get_nav( $offset ) {
-                $bp = buddypress();
 
                 $component_nav = $this->get_component_nav( $offset );
                 $primary_nav   = $component_nav->get_primary( array( 'slug' => $offset ), false );

src/bp-core/classes/class-bp-invitation-manager.php

@@ -169 +169 @@
          * @return bool The result of `run_send_action()`.
          */
         public function send_invitation_by_id( $invitation_id = 0, $args = array() ) {
-                $updated = false;
 
                 $invitation = new BP_Invitation( $invitation_id );
 
@@ -327 +326 @@
          * @return bool The result of `run_send_action()`.
          */
         public function send_request_notification_by_id( $request_id = 0, $args = array() ) {
-                $updated = false;
 
                 $request = new BP_Invitation( $request_id );
 

src/bp-core/classes/class-bp-media-extractor.php

@@ -519 +519 @@
          */
         protected function extract_embeds( $richtext, $plaintext, $extra_args = array() ) {
                 $data   = array( 'has' => array( 'embeds' => 0 ), 'embeds' => array() );
-                $embeds = array();
 
                 if ( ! function_exists( '_wp_oembed_get_object' ) ) {
                         require( ABSPATH . WPINC . '/class-oembed.php' );