Skip to:
Content

BuddyPress.org

Opened 6 weeks ago

Closed 6 weeks ago

#8321 closed enhancement (fixed)

Add delete confirmation screen for XProfile fields

Reported by: oztaser Owned by: slaFFik
Milestone: 7.0.0 Priority: normal
Severity: normal Version:
Component: Administration Keywords: has-patch commit
Cc:

Description

Based on @imath's suggestion in 8305, we should add a delete confirmation screen to xprofile fields for better user experience.

Attachments (3)

8321.patch (5.5 KB) - added by oztaser 6 weeks ago.
8321.improvements.patch (2.0 KB) - added by imath 6 weeks ago.
8321-2.patch (5.7 KB) - added by oztaser 6 weeks ago.

Download all attachments as: .zip

Change History (9)

@oztaser
6 weeks ago

#1 @imath
6 weeks ago

  • Keywords has-patch added
  • Milestone changed from Awaiting Review to 7.0.0

Awesome @oztaser. Thanks a lot for this new patch. I'll look into it and review it asap.

#2 @imath
6 weeks ago

  • Keywords needs-refresh added; has-patch removed

Hi @oztaser

I've just tested your patch. It works great. Thanks again for your work on this. I believe we should improve it a bit:

  1. making sure the i18n function are not using PHP code inside them. Instead of <?php esc_html_e( sprintf ( 'Delete %s', $field_type ), 'buddypress' ) ?> we should use <?php printf( esc_html__( 'Delete %s', 'buddypress' ), $field_type ); ?>.
  2. making sure there's a final ; after inline PHP functions.

8321.improvements.patch is containing these improvements.

@oztaser
6 weeks ago

#3 @oztaser
6 weeks ago

Hi @imath,

Thanks for the review and suggestions. I added your improvements to my patch and I'll keep these in my mind for future patches :)
Thanks again.

#4 @imath
6 weeks ago

  • Keywords has-patch commit added; needs-refresh removed

Awesome! You're welcome & thanks a lot for updating the patch. I'll commit it asap.

This ticket was mentioned in Slack in #buddypress by imath. View the logs.


6 weeks ago

#6 @imath
6 weeks ago

  • Resolution set to fixed
  • Status changed from new to closed

In 12676:

BP xProfile: add a delete confirmation screen for fields

Props oztaser

Fixes #8321

Note: See TracTickets for help on using tickets.