Add delete confirmation screen for XProfile fields

[oztaser]

Based on @imath's suggestion in ​8305, we should add a delete confirmation screen to xprofile fields for better user experience.

[imath]

Awesome @oztaser. Thanks a lot for this new patch. I'll look into it and review it asap.

[imath]

Hi @oztaser

I've just tested your patch. It works great. Thanks again for your work on this. I believe we should improve it a bit:

1. making sure the i18n function are not using PHP code inside them. Instead of <?php esc_html_e( sprintf ( 'Delete %s', $field_type ), 'buddypress' ) ?> we should use <?php printf( esc_html__( 'Delete %s', 'buddypress' ), $field_type ); ?>.
2. making sure there's a final ; after inline PHP functions.

8321.improvements.patch is containing these improvements.

[oztaser]

Hi @imath,

Thanks for the review and suggestions. I added your improvements to my patch and I'll keep these in my mind for future patches :)
Thanks again.

[imath]

Awesome! You're welcome & thanks a lot for updating the patch. I'll commit it asap.

[imath]

In 12676:

BP xProfile: add a delete confirmation screen for fields

Props oztaser

Fixes #8321