Add regular delete confirmation screen for XProfile field groups

[oztaser]

It will be good to add a js confirm to the delete link because users can accidentally click.

[imath]

Hi @oztaser

Thanks for this new contribution, I agree 💯. But just as I've commented on your ticket about the activity delete link, could we use a regular confirmation screen instead of the JavaScript confirm ?

Also, what about adding the delete link into the edit xProfile page, just like you suggested for the activity ?

[oztaser]

Hi @imath,

Thanks for your suggestion. I am gonna work on it.

[oztaser]

I added a regular confirmation screen for field groups and added the delete link into the edit field group page.

[imath]

Hi @oztaser

I just had a look at your patch and I've tested it. It's a very interesting work. Thanks a lot.

1. Suggestion:

// Let's use strict comparison at line 90 like:
in_array( $mode, array( 'delete_group', 'do_delete_group' ), true )

2. The Base group is required and not deletable

Into the edit group page, you should only include the delete link if the edited group is not the Base one.

3. What about confirming fields deletion?

I'm wondering if we should also add this confirmation step for fields. Would it be too annoying at usage?

[oztaser]

Hi again,

I've updated the patch for your first two suggestions.

What about confirming fields deletion?

I believe accidentally losing data is more annoying than confirmation screen so I think confirmation is always good for user experience.

I also can work on it if you think we should add the screen.

[imath]

Hi @oztaser

Thanks a lot for updating the patch and sorry it took me so long to review it. I believe it's ready to be committed so I'll do it in a few minutes.

I also can work on it if you think we should add the screen.

I think so and that would be awesome!

[imath]

In 12660:

xProfile Group Admin: add confirmation screen for the delete action

Props oztaser

Fixes #8305