Skip to:
Content

BuddyPress.org

Opened 5 weeks ago

Closed 12 days ago

#8322 closed task (fixed)

Ensure compatibility with PHPMailer v6.0

Reported by: Hareesh Pillai Owned by: DJPaul
Milestone: 6.2.0 Priority: high
Severity: normal Version:
Component: Emails Keywords: has-patch reporter-feedback dev-feedback
Cc:

Description

There is a major update in the PHPMailer library in core. This is scheduled to be released with WP 5.5 due in a few weeks. More details on the Make Core blog post: https://make.wordpress.org/core/2020/07/01/external-library-updates-in-wordpress-5-5-call-for-testing/

Creating this ticket to follow up and ensure compatibility with the latest version bundled in core.

Attachments (1)

8322.patch (6.5 KB) - added by imath 4 weeks ago.

Download all attachments as: .zip

Change History (10)

#1 @imath
5 weeks ago

  • Milestone changed from Awaiting Review to 7.0.0

I agree, thanks for creating this ticket.

@imath
4 weeks ago

#2 @imath
4 weeks ago

  • Keywords has-patch reporter-feedback dev-feedback added; needs-patch removed

Hi!

8322.patch is making sure BuddyPress is using PHPMailer version 6.0 if the WordPress version is >= 5.5, otherwise it keeps on using PHPMailer version 5.2 for the previous version of WordPress we support.

I've tested the patch in WP 5.5 and WP 5.4 successfully.

@hareesh-pillai can you test it and confirm everything is fine?

#3 @imath
4 weeks ago

  • Milestone changed from 7.0.0 to 6.2.0
  • Priority changed from normal to high

As WordPress 5.5 is expected in august, I think we probably need to achieve this task earlier than our 7.0 release.

#4 @man4toman
4 weeks ago

Hi @imath
I've tested the patch with WordPress "5.5", everything works fine.

Thanks

#5 @imath
4 weeks ago

Hi @man4toman

Thanks a lot for your tests 👍.

This ticket was mentioned in Slack in #buddypress by imath. View the logs.


3 weeks ago

#7 @imath
3 weeks ago

Hi everyone,

Here's a quick summary of our latest dev-chat discussions about this ticket. WordPress 5.5 is slated for August 11th. We plan to package a minor release (6.2.0) a bit before to include this fix. We'll also package a 6.2.0 beta release around july 22th to let BuddyPress plugin developers check their plugins with this change. From now to july 22th, you're welcome to test the patch in WordPress 5.5 (WP trunk) and in previous versions of WordPress the BP 6.0 branch is supporting (5.4 to 4.8). If you find something weird about your tests, please share it on this ticket.

I've just ran our PHPunit test suite successfully having the patch applyed in WordPress 5.5 (WP trunk) and in WordPress 5.4.3.

So far so good! Thanks in advance for your contributions.

#8 @imath
12 days ago

In 12687:

Emails: ensure compatibility with PHPMailer 6.0

Since version 5.5, WordPress has deprecated version 5.2 of PHPMailer in favor of its 6.0 version. We are using this library for our BP Emails feature. To ensure compatibility with this new version of WordPress as well as with the previous versions we are supporting (4.8 to 5.4), we need to make sure to use the right version of PHPMailer according the version of WordPress installed.

Props hareesh-pillai, man4toman

See #8322 (trunk)

#9 @imath
12 days ago

  • Resolution set to fixed
  • Status changed from new to closed

In 12688:

Emails: ensure compatibility with PHPMailer 6.0

Since version 5.5, WordPress has deprecated version 5.2 of PHPMailer in favor of its 6.0 version. We are using this library for our BP Emails feature. To ensure compatibility with this new version of WordPress as well as with the previous versions we are supporting (4.8 to 5.4), we need to make sure to use the right version of PHPMailer according to the version of WordPress installed.

Props hareesh-pillai, man4toman

Fixes #8322 (6.0 branch)

Note: See TracTickets for help on using tickets.