Skip to:
Content

Opened 17 months ago

Closed 15 months ago

Last modified 12 months ago

#6901 closed defect (bug) (fixed)

Avoid using HTML tags in translation strings (bp-notifications/classes/class-bp-notifications-component.php)

Reported by: ramiy Owned by: boonebgorges
Milestone: 2.6 Priority: normal
Severity: normal Version:
Component: I18N Keywords: has-patch
Cc:

Description

Old strings:

  • Notifications <span class="%s">%s</span>
  • Notifications <span class="count">%s</span>
  • Unread <span class="count">%s</span>

New string:

  • Notifications %s
  • Notifications %s
  • Unread %s

Attachments (1)

6901.patch (2.0 KB) - added by ramiy 17 months ago.

Download all attachments as: .zip

Change History (6)

@ramiy
17 months ago

#1 @DJPaul
17 months ago

  • Milestone changed from Awaiting Review to 2.5

#2 @DJPaul
17 months ago

  • Milestone changed from 2.5 to Under Consideration

The patch provides new placeholder tokens in the strings, but I believe there should be a translator comment explaining the values they will be replaced with.

#3 @boonebgorges
15 months ago

  • Milestone changed from Under Consideration to 2.6

#4 @boonebgorges
15 months ago

  • Owner set to boonebgorges
  • Resolution set to fixed
  • Status changed from new to closed

In 10675:

Remove markup from translatable strings when building Notifications nav items.

Props ramiy.
Fixes #6901.

#5 @DJPaul
12 months ago

  • Component changed from Locale - i18n to I18N
Note: See TracTickets for help on using tickets.