Skip to:
Content

BuddyPress.org

Opened 11 years ago

Closed 11 years ago

Last modified 10 years ago

#6902 closed defect (bug) (fixed)

Avoid using HTML tags in translation strings (bp-friends/classes/class-bp-friends-component.php)

Reported by: ramiy Owned by: boonebgorges
Priority: normal Milestone: 2.6
Component: I18N Version:
Severity: normal Keywords: has-patch
Cc:

Description

Old strings:

  • Friends <span class="%s">%s</span>
  • Friends <span class="count">%s</span>
  • Pending Requests <span class="count">%s</span>

New strings:

  • Friends %s
  • Friends %s
  • Pending Requests %s

Attachments (1)

6902.patch​ (1.9 KB ) - added by ramiy 11 years ago.

Download all attachments as: .zip

Change History (6)

@ramiy
11 years ago

#1 @DJPaul
11 years ago

  • Milestone Awaiting Review → 2.5

#2 @DJPaul
11 years ago

  • Milestone 2.5 → Under Consideration

The patch provides a new placeholder token in the string, but I believe there should be a translator comment explaining the value it will be replaced with.

#3 @boonebgorges
11 years ago

  • Owner set to boonebgorges
  • Resolution → fixed
  • Status new → closed

In 10676:

Remove markup from translatable strings when building Friends nav items.

Props ramiy.
Fixes #6902.

#4 @DJPaul
11 years ago

  • Milestone Under Consideration → 2.6

#5 @DJPaul
10 years ago

  • Component Locale - i18n → I18N
Note: See TracTickets for help on using tickets.