Changeset 10675

Timestamp:

03/23/2016 02:44:16 PM (11 years ago)

Author:

boonebgorges

Message:

Remove markup from translatable strings when building Notifications nav items.

Props ramiy.
Fixes #6901.

File:

• trunk/src/bp-notifications/classes/class-bp-notifications-component.php (modified) (2 diffs)

trunk/src/bp-notifications/classes/class-bp-notifications-component.php

@@ -126 +126 @@
                         $count    = bp_notifications_get_unread_notification_count( bp_displayed_user_id() );
                         $class    = ( 0 === $count ) ? 'no-count' : 'count';
-                        $nav_name = sprintf( _x( 'Notifications <span class="%s">%s</span>', 'Profile screen nav', 'buddypress' ), esc_attr( $class ), bp_core_number_format( $count ) );
+                        $nav_name = sprintf(
+                                /* translators: %s: Unread notification count for the current user */
+                                _x( 'Notifications %s', 'Profile screen nav', 'buddypress' ),
+                                sprintf(
+                                        '<span class="%s">%s</span>',
+                                        esc_attr( $class ),
+                                        bp_core_number_format( $count )
+                                )
+                        );
                 } else {
                         $nav_name = _x( 'Notifications', 'Profile screen nav', 'buddypress' );
@@ -189 +197 @@
                         $count = bp_notifications_get_unread_notification_count( bp_loggedin_user_id() );
                         if ( ! empty( $count ) ) {
-                                $title  = sprintf( _x( 'Notifications <span class="count">%s</span>', 'My Account Notification pending', 'buddypress' ), bp_core_number_format( $count ) );
-                                $unread = sprintf( _x( 'Unread <span class="count">%s</span>',        'My Account Notification pending', 'buddypress' ), bp_core_number_format( $count ) );
+                                $title = sprintf(
+                                        /* translators: %s: Unread notification count for the current user */
+                                        _x( 'Notifications %s', 'My Account Notification pending', 'buddypress' ),
+                                        '<span class="count">' . bp_core_number_format( $count ) . '</span>'
+                                );
+                                $unread = sprintf(
+                                        /* translators: %s: Unread notification count for the current user */
+                                        _x( 'Unread %s', 'My Account Notification pending', 'buddypress' ),
+                                        '<span class="count">' . bp_core_number_format( $count ) . '</span>'
+                                );
                         } else {
                                 $title  = _x( 'Notifications', 'My Account Notification',         'buddypress' );