Avoid using HTML tags in translation strings (bp-settings/bp-settings-template.php)

[ramiy]

Old string:

• There is a pending change of your email address to %1$s.<br />Check your email (%2$s) for the verification link. <a href="%3$s">Cancel</a>

New strings:

• There is a pending change of your email address to %s.
• Check your email (%s) for the verification link.
• Cancel

[DJPaul]

I don't like this patch because it splits a paragraph into multiple phrases. I expect there may be languages where people want to re-order the sentences, or continue to have just one. I can see you've tried to tackle this by introducing a line break, but I think that's a worse solution than leaving this string as it is.

[boonebgorges]

'Cancel' as a standalone string here probably won't work. 'Cancel' is generally used as button text, which it is not in this case, so it's possible that some locales will want to translate it differently. So we need either (a) to combine it with more of the string, (b) turn it into a button, (c) change it to _x() and add context, or (d) change the wording altogether so that the context is more obvious. For accessibility reasons, I think that (d) is probably the best option.

See 6900.diff​.

[DJPaul]

+1

[dcavins]

In 10689:

Improve translation strings in email change notice.

Move HTML tags out of translation strings
when possible.

Props ramiy, DJPaul, boonebgorges.

Fixes #6900.