Skip to:

Opened 2 years ago

Closed 2 years ago

Last modified 21 months ago

#6899 closed defect (bug) (fixed)

Avoid using HTML tags in translation strings (bp-blogs/classes/class-bp-blogs-component.php)

Reported by: ramiy Owned by: Boone Gorges
Milestone: 2.6 Priority: normal
Severity: normal Version:
Component: I18N Keywords: has-patch


See the attaches patch.

Old string:

  • Sites <span class="%s">%s</span>

New string:

  • Sites %s

Attachments (1)

6899.patch (862 bytes) - added by ramiy 2 years ago.

Download all attachments as: .zip

Change History (6)

2 years ago

#1 @Paul Gibbs
2 years ago

  • Milestone changed from Awaiting Review to 2.5

#2 @Paul Gibbs
2 years ago

  • Milestone changed from 2.5 to Under Consideration

The patch provides a new placeholder token in the string, but I believe there should be a translator comment explaining the value it will be replaced with.

#3 @Boone Gorges
2 years ago

  • Milestone changed from Under Consideration to 2.6

#4 @Boone Gorges
2 years ago

  • Owner set to Boone Gorges
  • Resolution set to fixed
  • Status changed from new to closed

In 10674:

Avoid markup in translatable string when building Sites navigation item.

Props ramiy.
Fixes #6899.

#5 @Paul Gibbs
21 months ago

  • Component changed from Locale - i18n to I18N
Note: See TracTickets for help on using tickets.