Skip to:
Content

BuddyPress.org

Opened 9 years ago

Closed 9 years ago

Last modified 8 years ago

#6898 closed defect (bug) (no action required)

Avoid using HTML tags in translation strings (bp-core/classes/class-bp-admin.php)

Reported by: ramiy's profile ramiy Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: I18N Keywords: has-patch
Cc:

Description

See the attaches patch.

Attachments (2)

6898.patch​ (1.1 KB) - added by ramiy 9 years ago.
6898.2.patch​ (1.0 KB) - added by ramiy 9 years ago.

Download all attachments as: .zip

Change History (8)

@ramiy
9 years ago

#1 @DJPaul
9 years ago

  • Milestone changed from Awaiting Review to 2.5

#2 @DJPaul
9 years ago

  • Milestone changed from 2.5 to Under Consideration

I don't like this patch because it splits a paragraph into two sentences. I expect there may be languages where people want to re-order the sentences, or continue to have just one for both.

There's also no benefit to providing a URL for translation as the project hasn't tackled translating its codex (yet).

#3 @ramiy
9 years ago

@DJPaul

This patch is splitting the original string into two strings. The first string is an informative text where you inform the user about the community upload. The second string is a call-to-action.

But I agree with you that we need to remove the codex link translation string.

Old string:

  • Your community can now upload cover photos for their user profiles and groups. <a href="%s">Learn more &rarr;</a>

New strings:

  • Your community can now upload cover photos for their user profiles and groups.
  • Learn more &rarr;

@ramiy
9 years ago

This ticket was mentioned in ​Slack in #buddypress by djpaul. ​View the logs.
9 years ago

#5 @boonebgorges
9 years ago

  • Milestone Under Consideration deleted
  • Resolution set to invalid
  • Status changed from new to closed

I'm going to agree with @DJPaul on this one. "Learn more &rarr;" doesn't make much sense without the context of the previous sentence.

#6 @DJPaul
8 years ago

  • Component changed from Locale - i18n to I18N
Note: See TracTickets for help on using tickets.