xProfile Admin: Rich textarea display

[imath]

When viewing a rich textarea in the xprofile admin screen it takes almost the entire screen..

See:

I think we should control the number of rows of the wp_editor in this screen. See attached patch

[boonebgorges]

Thanks, imath.

6722.patch​ will not work. We use the same bp_xprofile_field_type_textarea_editor_args filter to generate the admin_field_html as well as the edit_field_html. Either (a) we need to split up the filter, either with a new filter name or with a $context argument, or (b) we fix this using a filter callback that does an is_admin() check or something like that.

A $context parameter seems the most flexible to me. It'll make it easier for plugins to modify these fields without having to hook in two separate places.

[imath]

Replying to boonebgorges:

A $context parameter seems the most flexible to me. It'll make it easier for plugins to modify these fields without having to hook in two separate places.

Thanks boonebgorges, I agree what about 02.patch ?

[boonebgorges]

Thanks, imath. I think this is pretty good. We should probably include a 'textarea_rows' value for the other instance of the filter as well, so that filtering functions will have predictable data to work with. (Also, the default of 20 is way too high when you're editing a user's profile in the Dashboard.)

[boonebgorges]

In 10328:

Specify richtext xprofile field editor height on a per-context basis.

When displaying the edit format preview on Dashboard > Users > Profile Fields,
the default 'textarea_rows' value of 20 was far too high. This changeset
changes it to 1, and specifies a value of 10 for other instances of the editor.

To accommodate these different values, a $context parameter is added to the
bp_xprofile_field_type_textarea_editor_args filter, with possible values
'edit' and 'admin'.

Props imath.
Fixes #6722.