Changeset 10328

Timestamp:

11/10/2015 10:54:14 PM (11 years ago)

Author:

boonebgorges

Message:

Specify richtext xprofile field editor height on a per-context basis.

When displaying the edit format preview on Dashboard > Users > Profile Fields,
the default 'textarea_rows' value of 20 was far too high. This changeset
changes it to 1, and specifies a value of 10 for other instances of the editor.

To accommodate these different values, a $context parameter is added to the
bp_xprofile_field_type_textarea_editor_args filter, with possible values
'edit' and 'admin'.

Props imath.
Fixes #6722.

File:

• trunk/src/bp-xprofile/classes/class-bp-xprofile-field-type-textarea.php (modified) (3 diffs)

trunk/src/bp-xprofile/classes/class-bp-xprofile-field-type-textarea.php

@@ -97 +97 @@
                          *     @type bool $media_buttons Whether to show media buttons. Default false.
                          *     @type bool $quicktags     Whether to show the quicktags buttons. Default true.
+                         *     @type int  $textarea_rows Number of rows to display in the editor. Defaults to 1 in the
+                         *                               'admin' context, and 10 in the 'edit' context.
                          * }
+                         * @param string $context The display context. 'edit' when the markup is intended for the
+                         *                        profile edit screen, 'admin' when intended for the Profile Fields
+                         *                        Dashboard panel.
                          */
                         $editor_args = apply_filters( 'bp_xprofile_field_type_textarea_editor_args', array(
@@ -103 +108 @@
                                 'media_buttons' => false,
                                 'quicktags'     => true,
-                        ) );
+                                'textarea_rows' => 10,
+                        ), 'edit' );
 
                         wp_editor(
@@ -142 +148 @@
                                 'media_buttons' => false,
                                 'quicktags'     => true,
-                        ) );
+                                'textarea_rows' => 1,
+                        ), 'admin' );
 
                         wp_editor(