Remove PHP4 Constructor backcompat method from BP_Groups_Widget class

[tw2113]

Not sure we need this any more.

/**
 * PHP4 constructor
 *
 * For backward compatibility only
 */
function bp_groups_widget() {
	$this->_construct();
}

Plus not seeing the _construct() method in the class anyway.

[boonebgorges]

Plus not seeing the _construct() method in the class anyway.

​https://buddypress.trac.wordpress.org/browser/trunk/src/bp-groups/bp-groups-widgets.php?marks=21-32#L20

But yes, we can remove the PHP4 constructor.

[tw2113]

Not arguing at all, but does it end up matching up with the single underscore vs double underscore? May be learning something new here myself.

[boonebgorges]

Ah, I didn't notice the single underscore. ​https://buddypress.trac.wordpress.org/changeset/4211 I'm not sure whether WP required PHP 5 at this time - if so, the groups widget would've thrown a fatal error on PHP4. So yeah, let's rip it out.

Easy props for a first-time contributor.

[sbrajesh]

It has been 8 weeks without any new patch, so here I am putting one.
The patch removes php4 style constructor and also cleans up the code to follow WP Coding standards.

[sbrajesh]

Remove php4 constructor and cleanup the code a little bit

[DJPaul]

Thanks @sbrajesh. We'll commit this in two parts.

[sbrajesh]

Thank you @DJPaul
Please do let me know if you want me to put it as 2 different patches.

[boonebgorges]

In 10440:

Remove PHP4-style constructor from BP_Groups_Widget.

The constructor is no longer needed, and contains a typo that would cause a
fatal error if it were ever called.

Props sbrajesh, tw2113.
See #6721.

[boonebgorges]

In 10441:

Improved coding standards in BP_Groups_Widget.

Props sbrajesh.
See #6721.

[boonebgorges]

In 10442:

Use selected() when building BP_Groups_Widget markup.

Props sbrajesh.
Fixes #6721.