Skip to:
Content

Opened 4 years ago

Closed 4 years ago

#5623 closed enhancement (fixed)

WP Admin Extended "self" profile

Reported by: imath Owned by:
Milestone: 2.1 Priority: normal
Severity: normal Version: 2.0
Component: Administration Keywords:
Cc:

Description

We've discussed about this previously (see this comment), and modemlooper posted #5521 about the fact the administrator wasn't able to view his profile.

The patch is adding the wp-admin/extended profile for all users wishing to edit their profile from the WordPress administration (including the administrator of course!).

I've tested it on non multisite, multisite and when BuddyPress is not activated on the network.

About Multisite where BuddyPress is network activated, i chose to use the /wp-admin/user/profile.php area to display the member's profile, as in WordPress, a member with no roles on any blogs is accessing his profile this way, so i've generalized to all users except super admins. As network admin is restricted to super admins, they are the only ones to access their profile from this area. In this config a regular user is accessing his extended profile using the my-account Admin bar menu once in any admin part of the network.
I think it's the best way to handle the multisite case as most users should only be members (with no roles on any site).

What is your opinion ?

Attachments (2)

5623.patch (17.2 KB) - added by imath 4 years ago.
5623.02.patch (408 bytes) - added by imath 4 years ago.

Download all attachments as: .zip

Change History (14)

@imath
4 years ago

This ticket was mentioned in IRC in #buddypress-dev by imathfromparis. View the logs.


4 years ago

#2 @boonebgorges
4 years ago

Marked #5651 as duplicate.

#3 @johnjamesjacoby
4 years ago

In 8431:

Member Admin -- bp_core_admin_user_row_actions():

  • Add "View" link to post-row actions.
  • Use: sprintf(), add_query_arg() for URL creation.
  • Update __() usages esc_html__().
  • Properly escape URL's.

See #5623.

#4 @johnjamesjacoby
4 years ago

In 8432:

Member Admin:

  • Allow admins to edit other admins.
  • Allow admins to edit their own profiles.
  • Replace our custom tabbed UL/LI interface with WordPress core H2 navigation (and update admin.css accordingly.)

See #5623.

#5 @johnjamesjacoby
4 years ago

In 8441:

First pass enhancements to BP_Members_Admin

  • Introduce extended profiles to /wp-admin/user/ dashboard.
  • More robust single-site, multi-site, multi-network support, with access to extended profile data at all appropriate levels based on installation type, current user role, etc...
  • Add post-row checks to ensure correct administrative access to other user's data.
  • Allow super admins to edit any other user, always.
  • Allow users to edit their own extended profiles.
  • Various verbiage changes for improved clarity and workflow.
  • Some monolithic functions broken down into smaller private methods.

There is more to do here, including unit test coverage to confirm no unintended user-data leakage or accidental capability escalation is occurring, testing with more esoteric WordPress installation types, etc...

Props imath for the original patch. See #5623.

@imath
4 years ago

#6 @imath
4 years ago

Great work johnjamesjacoby :)

I really like it a lot, i think the new row action to view the profile on front is a great idea !

i'll test the multisite not network activated "esoteric" one

In 5623.02.patch i'm just suggesting that $notice is initiated else we have a notice error.

#7 @johnjamesjacoby
4 years ago

In 8443:

Add missing $notice to suppress debug notices. Remove trailing whitespace and a few more code-clean-up bits. Props imath. See #5623.

#8 @johnjamesjacoby
4 years ago

In 8444:

Update bp_members_admin_user_stats metabox title to either include a display name, or fall back to ambiguous 'Member' verbiage if no name can be retrieved. See #5623.

#9 @johnjamesjacoby
4 years ago

In 8455:

Add support for editing extended member profiles via /network/site-users.php. See #5623.

#10 @johnjamesjacoby
4 years ago

In 8457:

Add styling for users list-table via /network/site-users.php. See #5623.

#11 @DJPaul
4 years ago

  • Keywords has-patch 2nd-opinion removed

Where are we up to with this? Is it done? :)

#12 @johnjamesjacoby
4 years ago

  • Resolution set to fixed
  • Status changed from new to closed

Works for me. Any issues should have their own tickets going forward.

Thanks all!

Note: See TracTickets for help on using tickets.