Skip to:
Content

BuddyPress.org

Opened 6 years ago

Closed 3 years ago

#5622 closed defect (bug) (wontfix)

Remove RTL CSS in favor of only generating RTL CSS as part of the new build tools

Reported by: netweb Owned by:
Milestone: Priority: low
Severity: minor Version:
Component: Core Keywords:
Cc:

Description

via DJPaul ticket:5160#comment:49

5160-remove-rtl-css.diff

  • The core team had (unfortunately, in private -- sorry) previously decided to keep RTL CSS files in trunk, mainly to support contributions to the project from people who expect RTL.

Thats fine, and would work fine similar to the imagemin and jshint tasks and have the compiled RTL CSS committed back to the /src folder.

  • I think this change will be a wontfix, but a new ticket would be the place to have a discussion about this if you feel strongly.

My opinion is indeed they are not needed, RTL is no longer an extra step, a second thought, it is now a feature of the build process and part of the workflow for any CSS change.

Anyway this can be easily implemented 'down the road', punt to Future Release or wontfix for use as a reference.

Change History (5)

#1 follow-up: @johnjamesjacoby
6 years ago

I prefer the bbPress method of making CSS changes to /src and running grunt build to test compiled changes, including right-to-left changes. As it sits right now it's impossible to do this without running the release build runner, which seems incorrect.

#2 in reply to: ↑ 1 ; follow-up: @DJPaul
6 years ago

Replying to johnjamesjacoby:

I prefer the bbPress method of making CSS changes to /src and running grunt build to test compiled changes

That doesn't seem directly related to this ticket, which is about removing RTL CSS files from trunk (and only generating them as part of a release step).

#3 in reply to: ↑ 2 @johnjamesjacoby
6 years ago

Replying to DJPaul:

That doesn't seem directly related to this ticket, which is about removing RTL CSS files from trunk (and only generating them as part of a release step).

This sounds directly in conflict with what you said previously here:

The core team had (unfortunately, in private -- sorry) previously decided to keep RTL CSS files in trunk, mainly to support contributions to the project from people who expect RTL.

#4 @DJPaul
5 years ago

  • Milestone changed from Awaiting Review to Future Release

#5 @DJPaul
3 years ago

  • Milestone Future Release deleted
  • Resolution set to wontfix
  • Status changed from new to closed

Closing this old, somewhat controversial ticket, as there's not been any interest shown in the suggestion in the last ~2 years.

Note: See TracTickets for help on using tickets.