Skip to:
Content

BuddyPress.org

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#5365 closed defect (bug) (fixed)

WP Admin BuddyPress profile & self profile

Reported by: imath Owned by: imath
Milestone: 2.0 Priority: normal
Severity: normal Version:
Component: Administration Keywords: has-patch commit
Cc:

Description

Hi,

I've noticed one of the things i was checking in my first versions of the patch is not there anymore. I was checking if the current user id was the same than the one of the user being edited in order to return without modifying the row actions. Meaning an administrator can only edit other users profile from this area.

I think we should stay with this logic. I've run some tests earlier today and if we were to allow an administrator to edit his BuddyPress (Community) profile from this new Administration screen, then we would also need to :

  • change the WordPress profile link from user-edit.php to profile.php if administrator is editing his profile,
  • as a result we would need to hook 'show_user_profile' in order to add our profile tabs,
  • then we would need to also include the custom css in the profile.php page,
  • then we should disable the ban/unban radio box to avoid the administrator to ban himself..

At the end, the Profile nav would also load for regular users, so we would need to check for the requested user_id to avoid loading the custom css and include some other checks on user's capacity to avoid inserting the profile tabs for regular users..

I think our main goal is to give the ability to an administrator to "moderate" his members profiles, not to edit his personal profile.

Finally the patch also makes sure we're on the bp-profile edit page before loading the javascript needed to this screen.

Attachments (1)

5365.diff (1.7 KB) - added by imath 6 years ago.

Download all attachments as: .zip

Change History (7)

@imath
6 years ago

#1 follow-up: @boonebgorges
6 years ago

  • Keywords commit added; 2nd-opinion removed

I removed the check when I was looking at the patch, because I didn't understand the motivation behind it.

In a perfect world, I think we *would* make it possible for users to edit their extended profile info from the Dashboard. Why not? But, if that's going to take a bunch of extra work, then I'm OK with doing what you suggest, at least for 2.0. If we get demand for such a feature in the future, we'll talk about it then.

#2 @imath
6 years ago

  • Owner set to imath
  • Resolution set to fixed
  • Status changed from new to closed

In 7784:

Makes sure the /wp-admin BuddyPress profile stays in the "edit other users" context.

The patch also checks the /wp-admin BuddyPress profile screen is requested before loading the needed javascript.

Fixes #5365

#3 in reply to: ↑ 1 @imath
6 years ago

Replying to boonebgorges:

In a perfect world, I think we *would* make it possible for users..

I didn't even think about this possibility, stayed in my idea where the Admin was "moderating" profiles. But you're right, this would be logic to make this feature available, the same way a user can edit his WordPress profile.

#4 follow-up: @modemlooper
6 years ago

Not having an admin Extended Profile is an issue when you want to add settings to extended profile that are admin only user settings.

#5 @boonebgorges
6 years ago

I'm not saying it's a bad idea to have it, just that it's not yet built.

#6 in reply to: ↑ 4 @imath
6 years ago

Replying to modemlooper:

Not having an admin Extended Profile is an issue when you want to add settings to extended profile that are admin only user settings.

Thanks for your opinion. Actually, what you say is not completely true. Modifying "self profile" is not yet available, but a super admin for instance can modify an admin profile.
I understand you need it for a project when reading #5521, it would be great to have your patch about it on this ticket.

Note: See TracTickets for help on using tickets.