Improve check for BP Classic Plugin

[samedwards]

Right now, checks for the BP classic plugin are done with a function_exists( 'bp_classic' ) conditional, which is checking for the existence of this function as defined in the BP Classic plugin. This relies on the alphabetical ordering of the active_plugins array (and of course the sorting of bp-classic before buddypress).

I ran across a situation where I was enabling the BP Classic plugin via a ​plugin manifest, which did not cause the active_plugins array to be sorted, and thus I got redefined function errors when BP Classic loaded after Buddypress.

A check to is_plugin_active() has the downside of requiring the BP Classic plugin to be installed in the correctly named folder, which is also not always a given, but I would suggest that the gating conditional being changed to function_exists() || is_plugin_active() should cover more possible circumstances.

[espellcaste]

@imath could you look into this?

[imath]

Absolutely, thanks for alerting me about it 👌

Trac ticket: ​https://buddypress.trac.wordpress.org/ticket/9181

[espellcaste]

In 14029:

Update the conditional that check if bp_classic is available.

Previously, we only checked if the bp_classic function was available, without checking if the plugin was also active.

Props imath, narenin, samedwards, and espellcaste.

Fixes #9181
Closes ​https://github.com/buddypress/buddypress/pull/371

[imath]

Unit tests are failing since this commit, we need to review the fix. See:

​https://github.com/buddypress/buddypress/commit/f351427acb60fc7e62452f1448586af18bd72d20

[imath]

In 14032:

Remove the is_plugin_active() polyfill

Fixes #9181