Skip to:
Content

BuddyPress.org

Opened 6 weeks ago

Closed 6 weeks ago

#9180 closed defect (bug) (fixed)

[BP Tools - Manage Optouts] A Blank Screen is the result when Bulk actions - Delete is applied when no opt-out entries have been selected

Reported by: emaralive's profile emaralive Owned by: imath's profile imath
Milestone: 14.0.0 Priority: normal
Severity: normal Version: 12.5.1
Component: Administration Keywords: has-screenshots has-patch dev-feedback
Cc:

Description

There are 2 (two) ways to achieve a blank screen from site.url/wp-admin/tools.php?page=bp-optouts page/screen.

Scenario 1

There is at least 1 (one) opt-out entry:

  1. Select Delete from Bulk actions dropdown menu.
  2. Click apply without selecting an opt-out entry.

Scenario 2

In the event that there are no opt-out entries, using a query string with an empty optout_id and action set to delete will be sufficient for demonstration, for example:

site.url/wp-admin/tools.php?page=bp-optouts&optout_id=0&action=delete


The result is a basically a blank screen, see screenshot - screenshot-win10-me-2024.06.10-17_09_54.png.

The patch fixes this issue by utilizing downstream code that provides a feedback message and a cancel button, see screenshot - screenshot-win10-me-2024.06.10-17_18_44.png.

Attachments (3)

screenshot-win10-me-2024.06.10-17_09_54.png (83.7 KB) - added by emaralive 6 weeks ago.
screenshot-win10-me-2024.06.10-17_09_54.png
screenshot-win10-me-2024.06.10-17_18_44.png (102.2 KB) - added by emaralive 6 weeks ago.
screenshot-win10-me-2024.06.10-17_18_44.png
9180.01.patch (705 bytes) - added by emaralive 6 weeks ago.
Initial patch

Download all attachments as: .zip

Change History (7)

@emaralive
6 weeks ago

screenshot-win10-me-2024.06.10-17_09_54.png

@emaralive
6 weeks ago

screenshot-win10-me-2024.06.10-17_18_44.png

@emaralive
6 weeks ago

Initial patch

This ticket was mentioned in Slack in #buddypress by emaralive. View the logs.


6 weeks ago

#2 @imath
6 weeks ago

Patch looks good to me, thanks for catching this issue. @dcavins can you have a look at it?

This ticket was mentioned in Slack in #buddypress by dcavins. View the logs.


6 weeks ago

#4 @imath
6 weeks ago

  • Owner set to imath
  • Resolution set to fixed
  • Status changed from new to closed

In 13926:

Avoid the BP Opt-outs Admin screen to be empty

Props emaralive

Fixes #9180

Note: See TracTickets for help on using tickets.