Skip to:
Content

BuddyPress.org

Opened 5 weeks ago

Closed 4 days ago

Last modified 4 days ago

#9182 closed defect (bug) (fixed)

The Notifications menu in WP 6.6 Admin Bar

Reported by: imath's profile imath Owned by:
Milestone: 14.0.0 Priority: normal
Severity: normal Version:
Component: Toolbar & Notifications Keywords: has-patch
Cc:

Description

It has been moved at the right of the my-account menu due to the fact WordPress removed a right float in 6.6.

See https://core.trac.wordpress.org/changeset/58215/

Change History (7)

This ticket was mentioned in PR #313 on buddypress/buddypress by imath.


5 weeks ago
#1

  • Keywords has-patch added; needs-patch removed

Makes sure the Notifications menu stays at the left of the My Account one

Trac ticket: https://buddypress.trac.wordpress.org/ticket/9182

#2 @johnjamesjacoby
5 weeks ago

Worth identifying what our intent is with regards to menu/tab-order & keyboard navigation.

I.E. are we trying to be first/last, or before/after anything specifically.

Not suggesting a change is necessary, only that it’s been a long while since our intent has been matched to our outcome here.

#3 @imath
5 weeks ago

Thanks for your feedback @johnjamesjacoby

I agree we'll need to leave the discussion open about menu/tab-order. For now I will only make sure it stays where it was before/after WP 6.6.

#4 @imath
5 weeks ago

In 13925:

Keep the Notifications Admin Bar menu before the "My Account" one

This commit’s goal is to make sure people testing WordPress >= 6.6-beta2 during BP 14.0.0 beta testing period won’t believe this is a bug we missed. We’ll need to perform another commit once stable WP 6.6 will be released for 12.0 branch.

See #9182
Closes https://github.com/buddypress/buddypress/pull/313

This ticket was mentioned in Slack in #buddypress by emaralive. View the logs.


5 days ago

#6 @imath
4 days ago

  • Resolution set to fixed
  • Status changed from new to closed

#7 @imath
4 days ago

  • Milestone changed from 12.6.0 to 14.0.0
Note: See TracTickets for help on using tickets.