Current Password Title on bp-legacy general Template File

[gingerbooch]

Hi,

The user profile general settings shows me a bug with bp-legacy template.
The current password input title shows this text :

Current Password <span>(required to update email or change current password)</span>

As you can read it, the <spans> are printed on screen.
I think there is an error in the template file :

~/buddypress/bp-templates/bp-legacy/buddypress/members/single/general.php

Line 24 is :

<label for="pwd"><?php esc_html_e( 'Current Password <span>(required to update email or change current password)</span>', 'buddypress' ); ?></label>

I think it should be :

<label for="pwd"><?php printf( esc_html__( 'Current Password %s', 'buddypress' ), '<span>' . esc_html__( '(required to update email or change current password)', 'buddypress' ) . '</span>' );?></label>

Can you fix it please ?

GB

[imath]

Hi @gingerbooch

Thanks a lot for your report and suggestion, we’ll fix this issue asap.

[imath]

In 13860:

BP Legacy: better escape the settings front screen current pwd label

• Split the translatable string in 2 parts and move out of it the <span> html tags.
• Add translators guide

Props gingerbooch

See #9155 (trunk)

[imath]

In 13861:

BP Legacy: better escape the settings front screen current pwd label

• Split the translatable string in 2 parts and move out of it the <span> html tags.
• Add translators guide

Props gingerbooch

Fixes #9155 (branch 12.0)

[gingerbooch]

Hi @imath ,

Thank you for the fix with the version 12.5.0.

[imath]

Hi @gingerbooch

yw 👌