Skip to:
Content

BuddyPress.org

Opened 2 months ago

Closed 2 months ago

Last modified 2 months ago

#9155 closed defect (bug) (fixed)

Current Password Title on bp-legacy general Template File

Reported by: gingerbooch's profile gingerbooch Owned by: imath's profile imath
Milestone: 12.5.0 Priority: normal
Severity: normal Version: 12.4.1
Component: Templates Keywords: needs-patch
Cc:

Description

Hi,

The user profile general settings shows me a bug with bp-legacy template.
The current password input title shows this text :

Current Password <span>(required to update email or change current password)</span>

As you can read it, the <spans> are printed on screen.
I think there is an error in the template file :

~/buddypress/bp-templates/bp-legacy/buddypress/members/single/general.php

Line 24 is :

<label for="pwd"><?php esc_html_e( 'Current Password <span>(required to update email or change current password)</span>', 'buddypress' ); ?></label>

I think it should be :

<label for="pwd"><?php printf( esc_html__( 'Current Password %s', 'buddypress' ), '<span>' . esc_html__( '(required to update email or change current password)', 'buddypress' ) . '</span>' );?></label>

Can you fix it please ?

GB

Change History (5)

#1 @imath
2 months ago

  • Component changed from Core to Templates
  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to 12.5.0
  • Version set to 12.4.1

Hi @gingerbooch

Thanks a lot for your report and suggestion, we’ll fix this issue asap.

#2 @imath
2 months ago

In 13860:

BP Legacy: better escape the settings front screen current pwd label

  • Split the translatable string in 2 parts and move out of it the <span> html tags.
  • Add translators guide

Props gingerbooch

See #9155 (trunk)

#3 @imath
2 months ago

  • Owner set to imath
  • Resolution set to fixed
  • Status changed from new to closed

In 13861:

BP Legacy: better escape the settings front screen current pwd label

  • Split the translatable string in 2 parts and move out of it the <span> html tags.
  • Add translators guide

Props gingerbooch

Fixes #9155 (branch 12.0)

#4 @gingerbooch
2 months ago

Hi @imath ,

Thank you for the fix with the version 12.5.0.

#5 @imath
2 months ago

Hi @gingerbooch

yw 👌

Note: See TracTickets for help on using tickets.