Skip to:
Content

BuddyPress.org

Opened 7 weeks ago

Closed 4 weeks ago

Last modified 4 weeks ago

#9154 closed defect (bug) (fixed)

BP Legacy: accepting a group invitation from the Groups directory fails

Reported by: imath's profile imath Owned by:
Milestone: 14.0.0 Priority: normal
Severity: normal Version: 10.0.0
Component: Templates Keywords: has-patch
Cc:

Description

It looks like I did wrong into this commit [13160]. It introduced a regression where clicking on the "Accept Invitation" from the Groups directory fails.

Looking at the commit, it doesn't make sense to perform a check on the Ajax action name as it's always 'joinleave_group'.

My idea is to pass the "real" action using the button's class (JavaScript).

Change History (4)

This ticket was mentioned in PR #292 on buddypress/buddypress by imath.


5 weeks ago
#1

  • Keywords has-patch added; needs-patch removed
  • In Groups template: use specific button arguments in case a user has been invited to join a public group (make it different than the Join Group button which fails on BP Legacy).
  • In BP Legacy, move the group request capability check into the right case (is currently in the accept invite one).

Trac ticket: https://buddypress.trac.wordpress.org/ticket/9154

This ticket was mentioned in Slack in #buddypress by imath. View the logs.


5 weeks ago

#3 @imath
4 weeks ago

  • Resolution set to fixed
  • Status changed from new to closed

In 13876:

Groups: improve the way BuddyPress handles public group invites

  • In bp_group_join_button(): use specific arguments in case a user has been invited to join a public group to generate the action button.
  • In BP Legacy, update the bp_legacy_theme_ajax_joinleave_group() ajax callback to move the group request capability check at the right place & remove a wrong extra check about the invite approvement case.

Fixes #9154
Closes https://github.com/buddypress/buddypress/pull/292

This ticket was mentioned in Slack in #buddypress by imath. View the logs.


4 weeks ago

Note: See TracTickets for help on using tickets.