Skip to:
Content

BuddyPress.org

Opened 2 years ago

Last modified 22 months ago

#9156 assigned enhancement

Messages: add support for paginating thread messages (in web version)

Reported by: espellcaste Owned by: espellcaste
Priority: normal Milestone: Up Next
Component: Messages Version: 14.0.0
Severity: normal Keywords: needs-patch needs-unit-tests
Cc:

Description

We added support for paginating thread messages at #9146 and #8597, but this only takes into account the BP REST API, not the web version which loads all private messages by default.

We discussed ​before about adding a theme support, so that we don't break the experience for themes that rely on the legacy experience.

add_theme_support(
    'buddypress',
    [
        'messages' => [ 'pagination' => true ]
    ]
);

Change History (4)

#1 @imath
2 years ago

  • Milestone Up Next → 15.0.0

This ticket was mentioned in ​Slack in #buddypress by espellcaste. ​View the logs.
2 years ago

#3 @espellcaste
2 years ago

  • Version → 14.0.0

#4 @espellcaste
22 months ago

  • Milestone 15.0.0 → Up Next
  • Priority high → normal

@imath I started to look at this and I'd like to make the case so that we don't use add_theme_support at all.

Adding pagination to the messages component touches different files and Template Packs. So checking support for this theme feature seems an overhead.

I also think this is the sort of change expected in a major version. If a community is loading +100 messages and suddenly it loads 10 messages paginated, that's not the sort of thing I'd consider bad at all.

What do you think?

Note: See TracTickets for help on using tickets.