Skip to:
Content

BuddyPress.org

Opened 5 weeks ago

Last modified 10 days ago

#8471 new defect (bug)

bp_core_new_nav_default() function is useless

Reported by: imath Owned by:
Milestone: 9.0.0 Priority: normal
Severity: normal Version: 2.6.0
Component: Core Keywords: needs-patch needs-testing
Cc:

Description

Reviewing 8139.current-action.patch about #8139 I've found, using bp_core_new_nav_default() function is making the BP Component hardcoded Default subnav unusable.

To reproduce, add a new bp-custom.php file with this code:

function bp_activity_component_new_default_subnav() {
	bp_core_new_nav_default(
		array(
			'parent_slug'     => bp_get_activity_slug(),
			'screen_function' => 'bp_activity_screen_mentions',
			'subnav_slug'     => 'mentions'
		)
	);

}
add_action( 'bp_init', 'bp_activity_component_new_default_subnav', 2000 );

When you go to the Activity user's primary nav, you will reach the mentions subnav. But then the just-me subnav can't be reached anymore (even if you add it manually to the URL).

I've explored the bp_core_new_nav_default() function and I have started to build a patch. It needs to be completed for components != Activity.

Maybe it's a bit late to include it for 8.0.0. But I'd like we talk about this ticket at least before eventually punting it.

Attachments (1)

8471.patch (5.3 KB) - added by imath 5 weeks ago.

Download all attachments as: .zip

Change History (4)

@imath
5 weeks ago

This ticket was mentioned in Slack in #buddypress by imath. View the logs.


5 weeks ago

#2 @imath
5 weeks ago

  • Keywords needs-patch needs-testing added
  • Milestone changed from 8.0.0 to Up Next

We need more testing about this change.

#3 @imath
10 days ago

  • Milestone changed from Up Next to 9.0.0
Note: See TracTickets for help on using tickets.