Opened 4 years ago
Closed 4 years ago
#8472 closed defect (bug) (fixed)
Incorrect Type check in Members generates extremely long SQL query
Reported by: |
|
Owned by: | |
---|---|---|---|
Milestone: | 8.0.0 | Priority: | normal |
Severity: | normal | Version: | 7.3.0 |
Component: | REST API | Keywords: | has-patch |
Cc: |
Description
Hi, I reported issue #8299 last year and @imath was able to fix it. It was a SQL overheat issue which was fixed by checking if the search_terms argument was null and setting it to false if no search term was passed.
His fix is on github here:​https://github.com/buddypress/BP-REST/commit/e20475ef1fcfdae4aad34e7c71aec5072b194a21
The issue was happening in groups, but I noticed that the same problem also happens in the members page.
I think the solution is to apply the same fix (which was applied on line 141 of class-bp-rest-group-membership-endpoint.php) to line 125 of class-bp-rest-members-endpoint.php.
Change History (4)
#2
@
4 years ago
- Keywords has-patch added; needs-patch removed
FYI I've just submitted a ​PR about it on the GH repo and ask for a review about it.
#4
@
4 years ago
- Resolution set to fixed
- Status changed from new to closed
It's fixed:
here's the commit: ​https://github.com/buddypress/BP-REST/commit/4856cc74be2f32612e852f832d6b69997ce1b6a7
Hi @comminski
Thanks for your report. I’ll look at it asap 👌