Skip to:
Content

BuddyPress.org

Opened 5 months ago

Closed 5 months ago

#8472 closed defect (bug) (fixed)

Incorrect Type check in Members generates extremely long SQL query

Reported by: comminski Owned by:
Milestone: 8.0.0 Priority: normal
Severity: normal Version: 7.3.0
Component: REST API Keywords: has-patch
Cc:

Description

Hi, I reported issue #8299 last year and @imath was able to fix it. It was a SQL overheat issue which was fixed by checking if the search_terms argument was null and setting it to false if no search term was passed.

His fix is on github here:​https://github.com/buddypress/BP-REST/commit/e20475ef1fcfdae4aad34e7c71aec5072b194a21

The issue was happening in groups, but I noticed that the same problem also happens in the members page.

I think the solution is to apply the same fix (which was applied on line 141 of class-bp-rest-group-membership-endpoint.php) to line 125 of class-bp-rest-members-endpoint.php.

Change History (4)

#1 @imath
5 months ago

  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to 8.0.0

Hi @comminski

Thanks for your report. I’ll look at it asap 👌

#2 @imath
5 months ago

  • Keywords has-patch added; needs-patch removed

FYI I've just submitted a ​PR about it on the GH repo and ask for a review about it.

#3 @comminski
5 months ago

Great, thanks for the update.

#4 @imath
5 months ago

  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.