Skip to:
Content

BuddyPress.org

Opened 2 months ago

Closed 2 months ago

Last modified 2 months ago

#8455 closed defect (bug) (fixed)

Fixes for xProfile field support for WordPress Profile Fields

Reported by: needle Owned by: imath
Milestone: 8.0.0 Priority: normal
Severity: normal Version:
Component: Extended Profile Keywords: has-patch commit
Cc:

Description

This patch provides a couple of fixes for #7162:

  1. Skips caching existing data for an xProfile field when it is a WordPress field
  2. Fixes a minor bug where the empty item's table_name is cleared

Part 1 allows existing xProfile fields to be converted from textbox to wp-textbox format by ignoring any pre-existing values retrieved by the uncached data query.

This allows people using the BP XProfile WP User Sync plugin to simply change the xProfile field type and then deactivate it in favour of the new BuddyPress sync functionality. There will be orphaned field data left in the *_bp_xprofile_data table, but I think this is of little practical consequence since the field IDs are still in use.

Part 2, as the summary says, simply prevents the WordPress xProfile field table_name property from being cleared prior to priming the cache.

Attachments (1)

8455.patch (1.0 KB) - added by needle 2 months ago.
Patch for #8455

Download all attachments as: .zip

Change History (5)

@needle
2 months ago

Patch for #8455

#1 @imath
2 months ago

  • Milestone changed from Awaiting Review to 8.0.0

Hi @needle

Thanks a lot for your report and patch, I'll look at it asap.

#2 @imath
2 months ago

  • Keywords commit added

It looks good 💪. I'm going to commit it asap. Thanks again.

#3 @imath
2 months ago

  • Owner set to imath
  • Resolution set to fixed
  • Status changed from assigned to closed

In 12888:

xProfile: skip caching existing data about fields of the WP field type

This allows existing xProfile fields to be converted from the textbox to the wp-textbox type (for example) by ignoring any pre-existing values retrieved by the uncached data query.

This commit also prevents the WordPress xProfile field $table_name property from being cleared prior to priming the cache.

Props needle

Fixes #8455

#4 @needle
2 months ago

Thanks @imath

Note: See TracTickets for help on using tickets.