Changeset 12888

Timestamp:

04/16/2021 06:49:37 PM (5 years ago)

Author:

imath

Message:

xProfile: skip caching existing data about fields of the WP field type

This allows existing xProfile fields to be converted from the textbox to the wp-textbox type (for example) by ignoring any pre-existing values retrieved by the uncached data query.

This commit also prevents the WordPress xProfile field $table_name property from being cleared prior to priming the cache.

Props needle

Fixes #8455

File:

• trunk/src/bp-xprofile/classes/class-bp-xprofile-profiledata.php (modified) (3 diffs)

trunk/src/bp-xprofile/classes/class-bp-xprofile-profiledata.php

@@ -358 +358 @@
 
                 // If a value was found, cache it.
-                if ( isset( $queried_data[ $field_id ] ) ) {
+                if ( isset( $queried_data[ $field_id ] ) && ! isset( $field_type_objects[ $field_id ]->wp_user_key ) ) {
                     wp_cache_set( $cache_key, $queried_data[ $field_id ], 'bp_xprofile_data' );
 
@@ -366 +366 @@
                     $d = new stdClass;
 
-                    // Check WordPress if it's a WordPress field.
+                    // Check if it's a WordPress field.
                     if ( isset( $field_type_objects[ $field_id ]->wp_user_key ) ) {
                         $meta          = $field_type_objects[ $field_id ]->get_field_value( $user_id, $field_id );
@@ -374 +374 @@
 
                     } else {
-                        $d->id    = '';
-                        $d->value = '';
+                        $d->id         = '';
+                        $d->value      = '';
+                        $d->table_name = '';
                     }
 
-                    $d->table_name   = '';
                     $d->user_id      = $user_id;
                     $d->field_id     = $field_id;