#8454 closed defect (bug) (fixed)
Feed link functions should short circuit when feeds are disabled
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 8.0.0 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Activity | Keywords: | has-patch |
Cc: |
Pull Requests
- Loading…
Note: See
TracTickets for help on using
tickets.
Hi @sippis
Thanks a lot for your feedback and for your contribution. It's nice to see you on this Trac 😍
I confirm we need to improve this part. Instead of make links return null, I chose to avoid to display the HTML output if the feeds are disabled. I also added some improvements to be able to deactivate all or specific feeds. The filter now returns a second parameter with the feed identifier.
Doing this:
add_filter( 'bp_activity_enable_feeds', '__return_false' );
is still disabling all feeds 😉I also added some BP Nouveau improvements as on Activity directory or on Member's activity pages the link was always the main activity feed, which is wrong. Now according to what you display you get the right feed. Eg: on the 'My Groups' tab you'll get the activity feeds of the groups you belong too.
Let's fix this in 8.0.0!
PS: I will close the other ticket as duplicate.