Bug: BP Nouveau accept invitation error

[meijioro]

I get a “There was a problem performing this action. Please try again.” notice error when I try to click the “Accept Invitation” button on one of the groups on the group page (mydomain.com/groups).

This seems to be only happening when using Nouveau. I tried removing all plugins and using Twenty Seventeen or Twenty Twenty theme. Both still give the error when I try to accept. When I try using Legacy instead, it works fine. It’s just Nouveau is broken. And it’s only where all groups are listed on the "/groups" page. Accepting in my manage profile area (the buttons are Accept & Reject are listed) works fine.

[imath]

Thanks for reporting this issue. I confirm I was able to reproduce. I'm going to work on a fix.

[imath]

​8396.patch is fixing the issue. I'll commit it asap.

[imath]

In 12890:

BP Nouveau: improve the way we get the nonce in JavaScript main file

Splitting the data-bp-nonce attribute to get Ajax buttons nonce is not the right way to do it. There can be situation where the _wpnonce URL param is not the last one (eg: the data-bp-nonce attribute of the Accept Group Invite button contains a redirect_to param). Using the bp.Nouveau.getLinkParams() function is fixing the issue.

Prop meijioro

Fixes #8396